[GitHub] [commons-fileupload] arturobernalg commented on pull request #69: FILEUPLOAD-318 - Use try with resource

2021-04-29 Thread GitBox
arturobernalg commented on pull request #69: URL: https://github.com/apache/commons-fileupload/pull/69#issuecomment-829399340 > Using printStacktrace() is definitely not sufficient as a means of error handling. Rethrow the Exception. Hi @jochenw what should i do with this PR?

[GitHub] [commons-fileupload] arturobernalg commented on pull request #69: FILEUPLOAD-318 - Use try with resource

2021-04-25 Thread GitBox
arturobernalg commented on pull request #69: URL: https://github.com/apache/commons-fileupload/pull/69#issuecomment-826323650 > Using printStacktrace() is definitely not sufficient as a means of error handling. Rethrow the Exception. Hi @jochenw What do you think about this new a

[GitHub] [commons-fileupload] arturobernalg commented on pull request #69: FILEUPLOAD-318 - Use try with resource

2021-04-25 Thread GitBox
arturobernalg commented on pull request #69: URL: https://github.com/apache/commons-fileupload/pull/69#issuecomment-826323650 > Using printStacktrace() is definitely not sufficient as a means of error handling. Rethrow the Exception. Hi @jochenw What do you think about this new a