darkma773r commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-1013783823
Woohoo! I vote to merge it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
darkma773r commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-1008425078
Awesome, @kinow! I'll take a look at this as soon as I get some time.
Unfortunately, that probably won't be for at least a few more days.
--
This is an automated
darkma773r commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-986136369
@kinow, I have a couple of concerns about the API still. That being said, I
don't want to single-handedly delay progress on the release, so please feel
free to
darkma773r commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-985507050
Cool! I'll try to take a look at this over the weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
darkma773r commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-963083902
@kinow
I agree with @gwlucastrig, that we should try to keep the API simple. It
might be helpful to take a step back and enumerate all of the use cases the API
darkma773r commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-959156762
I just had another thought on this: it strikes me that the main issue with
the generic `ImagerParser` format is how to deal
with format-agnostic code, mainly the
darkma773r commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-958597172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
darkma773r commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-958597172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
darkma773r commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-959156762
I just had another thought on this: it strikes me that the main issue with
the generic `ImagerParser` format is how to deal
with format-agnostic code, mainly the
darkma773r commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-958597172
@kinow
> If the JpegImageParser requires a parameter different than the
TiffImageParser, I assume we would have to create a new JpegImagingParameter.
In that
darkma773r commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-955197158
I just made a merge request on this branch in your repo, @kinow:
https://github.com/kinow/commons-imaging/pull/36. Let me know what you think.
--
This is an
darkma773r commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-953743996
Hello again. Apologies for my silence here. I've been meaning to revisit
this but just haven't gotten to it. I'll try to spend some time with this over
the next
12 matches
Mail list logo
