[GitHub] [commons-imaging] garydgregory commented on a diff in pull request #318: Imaging-316: Add support for BigTIFF format

2023-09-19 Thread via GitHub
garydgregory commented on code in PR #318: URL: https://github.com/apache/commons-imaging/pull/318#discussion_r1330151666 ## src/main/java/org/apache/commons/imaging/formats/tiff/TiffReader.java: ## @@ -455,27 +473,55 @@ private TiffHeader readTiffHeader(final ByteSource byteSo

[GitHub] [commons-imaging] garydgregory commented on a diff in pull request #318: Imaging-316: Add support for BigTIFF format

2023-09-19 Thread via GitHub
garydgregory commented on code in PR #318: URL: https://github.com/apache/commons-imaging/pull/318#discussion_r1330152071 ## src/main/java/org/apache/commons/imaging/common/BinaryFunctions.java: ## @@ -177,6 +177,44 @@ public static int read4Bytes(final String name, final Input

[GitHub] [commons-imaging] garydgregory commented on a diff in pull request #318: Imaging-316: Add support for BigTIFF format

2023-09-27 Thread via GitHub
garydgregory commented on code in PR #318: URL: https://github.com/apache/commons-imaging/pull/318#discussion_r1338737448 ## src/main/java/org/apache/commons/imaging/formats/tiff/TiffField.java: ## @@ -234,6 +234,14 @@ public int[] getIntArrayValue() throws ImagingException {

[GitHub] [commons-imaging] garydgregory commented on a diff in pull request #318: [IMAGING-316] Add support for BigTIFF format

2023-09-29 Thread via GitHub
garydgregory commented on code in PR #318: URL: https://github.com/apache/commons-imaging/pull/318#discussion_r1341381002 ## src/main/java/org/apache/commons/imaging/formats/tiff/TiffReader.java: ## @@ -16,27 +16,29 @@ */ package org.apache.commons.imaging.formats.tiff; -im