gwlucastrig commented on a change in pull request #98:
URL: https://github.com/apache/commons-imaging/pull/98#discussion_r500170065
##########
File path:
src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageData.java
##########
@@ -53,14 +53,17 @@ public boolean stripsNotTiles() {
@Override
public ImageDataReader getDataReader(final TiffDirectory directory,
- final PhotometricInterpreter photometricInterpreter,
- final int bitsPerPixel, final int[] bitsPerSample, final int
predictor,
- final int samplesPerPixel, final int width, final int height,
final int compression,
- final ByteOrder byteOrder) throws IOException, ImageReadException {
+ final PhotometricInterpreter photometricInterpreter,
+ final int bitsPerPixel, final int[] bitsPerSample, final int
predictor,
+ final int samplesPerPixel, final int width, final int height,
+ final int compression,
+ final int planarConfiguration,
Review comment:
Making planar configuration an enum would be a good idea. I see that
you self-assigned this. Does that mean you'll be making the change?
In the future, making predictor and compression also be enum's would also
make sense. When I am reading the data-reader code I often lose track of what
the numeric values indicate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
