kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-1013758565
@darkma773r applied all changes exactly as suggested, and created two
follow-up JIRA issues. Unless there are any last minute review requests, I
think we are ready to
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-1008428517
Not a problem @darkma773r , I'll work on other things, including trying to
look at that fuzzy-search issue GEOMETRY-142. Thanks!!!
--
This is an automated message from
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-1007768801
@gwlucastrig , @darkma773r I believe this is ready for review again. And I
think it is really close to being ready to be merged! :tada:
@darkma773r I've removed the
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-1007768801
@gwlucastrig , @darkma773r I believe this is ready for review again. And I
think it is really close to being ready to be merged! :tada:
@darkma773r I've removed the
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-1003833509
Rebased and addressed some of the excellent feedback. Thanks @darkma773r !
I'm looking at the JPEG & TIFF relationship issue as that's easier to fix.
Then I think we
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-963088960
Agreed @darkma773r , +1 on @gwlucastrig suggestion too. Let's review Imaging
class. Will start thinking on what/how to change
--
This is an automated message from the
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-961461586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-961461586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-961799086
@darkma773r I've been thinking the types we use in that class, like
`ImageParser`, `ImagingParameter`, and `ImageFormat`. When we pass the
arguments to `writeImage`, for
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-961796289
That is a good point @gwlucastrig , and I have no objections to massaging
the code of the `Imaging` class. I will spend some time thinking about that,
and seeing if/when
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-961461586
>I just had another thought on this: it strikes me that the main issue with
the generic ImagerParser format is how to deal
with format-agnostic code, mainly the utility
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-958618064
>> If the JpegImageParser requires a parameter different than the
TiffImageParser, I assume we would have to create a new JpegImagingParameter.
In that case, wouldn't we
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-958618064
>> If the JpegImageParser requires a parameter different than the
TiffImageParser, I assume we would have to create a new JpegImagingParameter.
In that case, wouldn't we
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-958618064
>> If the JpegImageParser requires a parameter different than the
TiffImageParser, I assume we would have to create a new JpegImagingParameter.
In that case, wouldn't we
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-958618064
>> If the JpegImageParser requires a parameter different than the
TiffImageParser, I assume we would have to create a new JpegImagingParameter.
In that case, wouldn't we
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-956081611
@darkma773r
Thanks a lot for creating that pull request. Really clever the intermediate
`GenericImageParser`. I liked it and might use it later! :+1:
A few
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-955198434
Thanks a lot @darkma773r !! Will take a look on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-953750338
No worries @darkma773r , thanks for having another look at this one!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-950461037
Hi @gwlucastrig we just need to sort out if the API needs to be redesigned
due to the generics suppressions or if that's something we can consider a 1.1
or 2.0 improvement.
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-950136340
Triaged issues today, and I think this is the last issue pending for 1.0
release. The others can still be fixed in 1.0.1, or 1.1.
--
This is an automated message from the
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-918771649
Hi @gwlucastrig
Thanks for the detailed example. The only part of the implementation that
bothers me is the static method.
>Finally, each parameters class
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-914929304
Just wrote an e-mail to commons-dev mailing list about the generics issue.
Let's wait and see if there's any feedback :+1:
--
This is an automated message from the
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-881833791
Excellent review @darkma773r! I've incorporated one of your suggestions
already, but will need a little more time to go over the other items. However,
having read your
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-841797895
Whew, I knew we relied on awt, but looks like we are using it in a lot more
places than I imagined. Let me update the PR to use a rectangle as ou suggested
@gwlucastrig .
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-841797895
Whew, I knew we relied on awt, but looks like we are using it in a lot more
places than I imagined. Let me update the PR to use a rectangle as ou suggested
@gwlucastrig .
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-841649340
If those classes are from awt, the issue is that we have a dependency to
java.desktop (I think that's the java module name) and also cause an issue to
users of the API that
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-841637202
@gwlucastrig the code is now compiling. I had to make more design decisions
than I expected to add the parameters. See `ImagingParameters` and the
implementations like
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-841605341
@gwlucastrig
>great suggestion from @gwlucastrig : "use one call for setSubImage, rather
than 4 separate calls for setSubImageX, Y, Width, Height."
I started
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-826703877
Note to self: rebase again, and check Tabs vs. Spaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-826283762
Whew, rebased after a few pull requests were merged :cold_sweat:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-826283762
Whew, rebased after a few pull requests were merged :cold_sweat:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-824644871
Now the code in `src/main` is using the `ImagingParameters` and subclasses.
If I have time tomorrow or over the weekend, will go through the pending
items. After
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-823975384
Rebased. Re-starting work soon, planning to finish by end of this month or
May. Then wrap up other issues, and try a 1.0 final release
--
This is an automated
kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-783729644
> Hey Bruno,
>
> Anything I can do to help with this?
>
> Gary
I thought it would be a simple task, but replacing the hashmaps by the new
object would
34 matches
Mail list logo
