[GitHub] [commons-imaging] kinow commented on pull request #173: ISSUE-311 support multivariable rasters

2021-10-13 Thread GitBox
kinow commented on pull request #173: URL: https://github.com/apache/commons-imaging/pull/173#issuecomment-942829570 >I've fixed most of the whitespace-related issues. So I hope the code will be easier to review. >Unfortunately, some of the Javadoc received different line-breaks, and I

[GitHub] [commons-imaging] kinow commented on pull request #173: ISSUE-311 support multivariable rasters

2021-10-18 Thread GitBox
kinow commented on pull request #173: URL: https://github.com/apache/commons-imaging/pull/173#issuecomment-946272094 > It was going well, but it may have fallen apart at the end. When I did a git rebase with a squash, git pulled in some merge commits with recent dependabot changes. Some of

[GitHub] [commons-imaging] kinow commented on pull request #173: ISSUE-311 support multivariable rasters

2021-10-18 Thread GitBox
kinow commented on pull request #173: URL: https://github.com/apache/commons-imaging/pull/173#issuecomment-946287465 Oh, spoke too fast I think? It actually says: >This branch cannot be rebased due to conflicts >Rebasing the commits of this branch on top of the base branch cannot b

[GitHub] [commons-imaging] kinow commented on pull request #173: ISSUE-311 support multivariable rasters

2021-10-18 Thread GitBox
kinow commented on pull request #173: URL: https://github.com/apache/commons-imaging/pull/173#issuecomment-946306018 @gwlucastrig I started fixing the conflicts, but then one of the commits was really confusing. I couldn't understand what had happened. You could try rebasing and fixing con