kinow opened a new pull request #63: [IMAGING-155]: cleaning up ImagingTest 
base class by removing createTempFile method and using the JDK File method 
instead
URL: https://github.com/apache/commons-imaging/pull/63
 
 
   As per title, the `ImagingTest` base class has most of the logic that is 
handling to traverse directories and load files, which is part of the problem 
described in IMAGING-155.
   
   This PR does not close IMAGING-155, but starts by removing the method 
`createTempFile` that also uses an instance `File` annotated by Junit's 
`TempDir` as base directory - turns out this directory is not really necessary 
as we only use the `File` created per method.
   
   There was also a similar method in `RoundTripBase` that was also removed in 
favor of the JDK's method.
   
   Further pull requests will keep tidying `ImagingTest`.
   
   Bruno

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to