[GitHub] [commons-imaging] pauldaustin commented on issue #43: Feature/deflate

2019-06-25 Thread GitBox
pauldaustin commented on issue #43: Feature/deflate URL: https://github.com/apache/commons-imaging/pull/43#issuecomment-505598032 @kinow That's great news thanks. This is an automated message from the Apache Git Service. To re

[GitHub] [commons-imaging] pauldaustin commented on issue #43: Feature/deflate

2019-06-25 Thread GitBox
pauldaustin commented on issue #43: Feature/deflate URL: https://github.com/apache/commons-imaging/pull/43#issuecomment-505591307 I'm giving up, seems to be a bunch of errors I'm not sure how to fix, or are in parts of the code I haven't changed. ---

[GitHub] [commons-imaging] pauldaustin commented on issue #43: Feature/deflate

2019-06-02 Thread GitBox
pauldaustin commented on issue #43: Feature/deflate URL: https://github.com/apache/commons-imaging/pull/43#issuecomment-498092319 I merged master into my branch to get the other changes. Maybe this will fix the PR check issues.

[GitHub] [commons-imaging] pauldaustin commented on issue #43: Feature/deflate

2019-05-31 Thread GitBox
pauldaustin commented on issue #43: Feature/deflate URL: https://github.com/apache/commons-imaging/pull/43#issuecomment-497746229 Looks like the formatter wouldn't have helped as the spaces were at the end of lines in the javadoc comment and it didn't strip them when I tried the formatter.

[GitHub] [commons-imaging] pauldaustin commented on issue #43: Feature/deflate

2019-05-31 Thread GitBox
pauldaustin commented on issue #43: Feature/deflate URL: https://github.com/apache/commons-imaging/pull/43#issuecomment-497743771 Do you know if there are an exported configurations for Eclipse code style, formatting and import ordering. I use that on my own projects so it automatically ge