[GitHub] [commons-io] adamretter commented on pull request #119: Add a MarkShieldInputStream

2020-06-05 Thread GitBox
adamretter commented on pull request #119: URL: https://github.com/apache/commons-io/pull/119#issuecomment-639768421 @garydgregory Could I get an update on this please? This is an automated message from the Apache Git Service

[GitHub] [commons-io] adamretter commented on pull request #119: Add a MarkShieldInputStream

2020-06-01 Thread GitBox
adamretter commented on pull request #119: URL: https://github.com/apache/commons-io/pull/119#issuecomment-637099087 @garydgregory If you look at java.io.InputStream source code - the default is to throw an exception when reset is called if mark is unsupported... so I am just following the

[GitHub] [commons-io] adamretter commented on pull request #119: Add a MarkShieldInputStream

2020-06-01 Thread GitBox
adamretter commented on pull request #119: URL: https://github.com/apache/commons-io/pull/119#issuecomment-636984631 @garydgregory Hmm I had not thought of that. Personally I prefer to have the separate classes... but I can refactor it if that's what is needed? What would happen to t