[GitHub] [commons-io] chadlwilson commented on pull request #319: Fixes regression on copyURLToFile with partial regression tests

2022-01-31 Thread GitBox
chadlwilson commented on pull request #319: URL: https://github.com/apache/commons-io/pull/319#issuecomment-1025911018 Thanks! I have got past this particular error and the bunch of tests that were triggering it, but now there seems to be another problem due to https://github.com/apache/co

[GitHub] [commons-io] chadlwilson commented on pull request #319: Fixes regression on copyURLToFile with partial regression tests

2022-01-30 Thread GitBox
chadlwilson commented on pull request #319: URL: https://github.com/apache/commons-io/pull/319#issuecomment-1025384907 Hmm, if it hasn't been set up on ci2/buildbot I'm a bit confused as to how those previous snapshots got there as https://builds.apache.org/job/Commons/job/commons-io/ seem

[GitHub] [commons-io] chadlwilson commented on pull request #319: Fixes regression on copyURLToFile with partial regression tests

2022-01-30 Thread GitBox
chadlwilson commented on pull request #319: URL: https://github.com/apache/commons-io/pull/319#issuecomment-1025365768 Does something need to be done to trigger a snapshot build off master? I thought they were dailies if there were any new commits, but I don't see new snapshot builds yet a

[GitHub] [commons-io] chadlwilson commented on pull request #319: Fixes regression on copyURLToFile with partial regression tests

2022-01-30 Thread GitBox
chadlwilson commented on pull request #319: URL: https://github.com/apache/commons-io/pull/319#issuecomment-1025159115 Okay thanks, will give it a go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [commons-io] chadlwilson commented on pull request #319: Fixes regression on copyURLToFile with partial regression tests

2022-01-27 Thread GitBox
chadlwilson commented on pull request #319: URL: https://github.com/apache/commons-io/pull/319#issuecomment-1023281649 > > If the intent is to re-use NIO logic, I suppose the `Files.copy` could be preceded by `Files.createDirectories(destination.getParentFile().toPath());` > > The usage