[GitHub] [commons-io] chadlwilson edited a comment on pull request #319: Fixes regression on copyURLToFile with partial regression tests

2022-01-30 Thread GitBox
chadlwilson edited a comment on pull request #319: URL: https://github.com/apache/commons-io/pull/319#issuecomment-1025159115 Okay thanks, will give it a go when the snapshot is rebuilt. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [commons-io] chadlwilson edited a comment on pull request #319: Fixes regression on copyURLToFile with partial regression tests

2022-01-25 Thread GitBox
chadlwilson edited a comment on pull request #319: URL: https://github.com/apache/commons-io/pull/319#issuecomment-1021213271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [commons-io] chadlwilson edited a comment on pull request #319: Fixes regression on copyURLToFile with partial regression tests

2022-01-25 Thread GitBox
chadlwilson edited a comment on pull request #319: URL: https://github.com/apache/commons-io/pull/319#issuecomment-1021213271 If the intent is to re-use NIO logic, I suppose the `Files.copy` could be preceded by `Files.createDirectories(destination.getParentFile().toPath());` The usa

[GitHub] [commons-io] chadlwilson edited a comment on pull request #319: Fixes regression on copyURLToFile with partial regression tests

2022-01-25 Thread GitBox
chadlwilson edited a comment on pull request #319: URL: https://github.com/apache/commons-io/pull/319#issuecomment-1021213271 If the intent is to re-use NIO logic, I suppose the `Files.copy` could be preceded by `Files.createDirectories(destination.getParentFile().toPath());` The usa