garydgregory commented on pull request #173:
URL: https://github.com/apache/commons-io/pull/173#issuecomment-742738847
@robtimus Merged to git master. Thank you for the PR :-)
This is an automated message from the Apache Git
garydgregory commented on pull request #173:
URL: https://github.com/apache/commons-io/pull/173#issuecomment-741818970
I will review all of this tomorrow (Thursday).
This is an automated message from the Apache Git Service.
garydgregory commented on pull request #173:
URL: https://github.com/apache/commons-io/pull/173#issuecomment-740189244
> I've come to like code that almost reads as if it's English. I don't get a
feeling about how to interpret the first one: "a CloseShieldInputStream on a
new
garydgregory commented on pull request #173:
URL: https://github.com/apache/commons-io/pull/173#issuecomment-739577418
Hi All:
I'm not a fan of the factory method name `dontClose()` as I usually only use
static imports for JUnit methods, and this it's also weird to me to read code
garydgregory commented on pull request #173:
URL: https://github.com/apache/commons-io/pull/173#issuecomment-739551169
Hi @robtimus
Please rebase on git master which should give you a green set of builds.
This is an
