[GitHub] [commons-io] garydgregory commented on pull request #319: Fixes regression on copyURLToFile with partial regression tests

2022-01-31 Thread GitBox
garydgregory commented on pull request #319: URL: https://github.com/apache/commons-io/pull/319#issuecomment-1025968843 Hi @chadlwilson Creating a new PR would be great. TY. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [commons-io] garydgregory commented on pull request #319: Fixes regression on copyURLToFile with partial regression tests

2022-01-31 Thread GitBox
garydgregory commented on pull request #319: URL: https://github.com/apache/commons-io/pull/319#issuecomment-1025656023 I just published a snapshot and reconfigured the Jenkins job to only use Java 8. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [commons-io] garydgregory commented on pull request #319: Fixes regression on copyURLToFile with partial regression tests

2022-01-30 Thread GitBox
garydgregory commented on pull request #319: URL: https://github.com/apache/commons-io/pull/319#issuecomment-1025376139 Someone has to set it up on https://ci2.apache.org/#/ IIRC -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [commons-io] garydgregory commented on pull request #319: Fixes regression on copyURLToFile with partial regression tests

2022-01-30 Thread GitBox
garydgregory commented on pull request #319: URL: https://github.com/apache/commons-io/pull/319#issuecomment-1025157666 Hello @chadlwilson I adapted the new tests and provided a different fix. Please test git master for your use case. TY! -- This is an automated message from the

[GitHub] [commons-io] garydgregory commented on pull request #319: Fixes regression on copyURLToFile with partial regression tests

2022-01-27 Thread GitBox
garydgregory commented on pull request #319: URL: https://github.com/apache/commons-io/pull/319#issuecomment-1023235829 > If the intent is to re-use NIO logic, I suppose the `Files.copy` could be preceded by `Files.createDirectories(destination.getParentFile().toPath());` > > The usa