[GitHub] [commons-io] garydgregory commented on pull request #74: Add new function: byteCountToDisplayRoundedSize

2023-07-02 Thread via GitHub
garydgregory commented on PR #74: URL: https://github.com/apache/commons-io/pull/74#issuecomment-1616692171 Closing, moving to Commons Text (presumably). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [commons-io] garydgregory commented on pull request #74: Add new function: byteCountToDisplayRoundedSize

2022-11-16 Thread GitBox
garydgregory commented on PR #74: URL: https://github.com/apache/commons-io/pull/74#issuecomment-1316844945 Hi @RockyMM Go for it ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [commons-io] garydgregory commented on pull request #74: Add new function: byteCountToDisplayRoundedSize

2022-11-14 Thread GitBox
garydgregory commented on PR #74: URL: https://github.com/apache/commons-io/pull/74#issuecomment-1313637404 Hello @zsoltii My main point is that the functionality should not have been put here in the first place, it has nothing to do with IO; consequently, let's not make it bigger. -

[GitHub] [commons-io] garydgregory commented on pull request #74: Add new function: byteCountToDisplayRoundedSize

2022-11-09 Thread GitBox
garydgregory commented on PR #74: URL: https://github.com/apache/commons-io/pull/74#issuecomment-1309304322 I do not think number-text conversion routines belong in Commons IO. Maybe in Commons Text? -- This is an automated message from the Apache Git Service. To respond to the messag