sebbASF commented on pull request #118:
URL: https://github.com/apache/commons-io/pull/118#issuecomment-669154882
Do you have any proof that using UnsyncBufferedReader etc in contentEquals
will result in a slow-down unless further changes are made to contentEquals?
If so, what
sebbASF commented on pull request #118:
URL: https://github.com/apache/commons-io/pull/118#issuecomment-669139532
Undynchronized should presumably be Unsynchronized?
However, I think that makes the class names rather long.
I think Unsync is clear enough as a prefix (and avoids the
sebbASF commented on pull request #118:
URL: https://github.com/apache/commons-io/pull/118#issuecomment-669097163
AFAICT the new classes UnsyncBufferedReader etc are not actually used
(except in test code).
I would expect all the contentEquals methods to remain exactly the same
sebbASF commented on pull request #118:
URL: https://github.com/apache/commons-io/pull/118#issuecomment-668293267
The original comparison methods are easy to follow.
It would be good to keep the same clarity by defining new versions of
BufferedReader that have good single-threaded
sebbASF commented on pull request #118:
URL: https://github.com/apache/commons-io/pull/118#issuecomment-665587079
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
