arturobernalg commented on PR #731:
URL: https://github.com/apache/commons-lang/pull/731#issuecomment-1140451648
Hi @garydgregory
I close the PR. but it is not clear to me who says or under what guidelines
it is "real practical need for functionality". I thought that the whole idea of
t
arturobernalg commented on PR #731:
URL: https://github.com/apache/commons-lang/pull/731#issuecomment-1140438556
> What is the use case? I do not mean "what does the code do". Are you
writing or maintaining Java tools lile Maven plugins or an IDE or something
like that? Or, is this PR a "th
arturobernalg commented on PR #731:
URL: https://github.com/apache/commons-lang/pull/731#issuecomment-1140291814
hi @aherbert
Do i have to do something else?
ty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
arturobernalg commented on pull request #731:
URL: https://github.com/apache/commons-lang/pull/731#issuecomment-801322756
HI @aherbert
Hi, thank you for the test case tip. Regarding with use bitwise operator IMO
it's more complex
TY
-
arturobernalg commented on pull request #731:
URL: https://github.com/apache/commons-lang/pull/731#issuecomment-801104206
> There are more rules to check here. You should also check the method is
not **final** using `Modifier.isFinal` which prevents being overridden.
>
> How to handl
