[GitHub] [commons-lang] debae commented on pull request #838: LANG-1677 : Add ReflectionDiffBuilder.setExcludeFieldNames(...) and DiffExclude a…

2023-04-27 Thread via GitHub
debae commented on PR #838: URL: https://github.com/apache/commons-lang/pull/838#issuecomment-1527014772 @kinow and @garydgregory Can you guys have another look at this PR, all remarks have been processed. -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [commons-lang] debae commented on pull request #838: LANG-1677 : Add ReflectionDiffBuilder.setExcludeFieldNames(...) and DiffExclude a…

2022-11-18 Thread GitBox
debae commented on PR #838: URL: https://github.com/apache/commons-lang/pull/838#issuecomment-1320414172 @garydgregory did you have the time too look into this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [commons-lang] debae commented on pull request #838: LANG-1677 : Add ReflectionDiffBuilder.setExcludeFieldNames(...) and DiffExclude a…

2022-09-16 Thread GitBox
debae commented on PR #838: URL: https://github.com/apache/commons-lang/pull/838#issuecomment-1249516337 @garydgregory friendly reminder on this PR , are requested changes are tackled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [commons-lang] debae commented on pull request #838: LANG-1677 : Add ReflectionDiffBuilder.setExcludeFieldNames(...) and DiffExclude a…

2022-02-08 Thread GitBox
debae commented on pull request #838: URL: https://github.com/apache/commons-lang/pull/838#issuecomment-1032768837 Hi @garydgregory I think all remarks have been resolved. Can you have another look at it and if not let me know. Thanks ! -- This is an automated message from the Apache Git

[GitHub] [commons-lang] debae commented on pull request #838: LANG-1677 : Add ReflectionDiffBuilder.setExcludeFieldNames(...) and DiffExclude a…

2021-12-21 Thread GitBox
debae commented on pull request #838: URL: https://github.com/apache/commons-lang/pull/838#issuecomment-999338912 > See my previous comment. Hi @garydgregory , extra testcases have been added. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [commons-lang] debae commented on pull request #838: LANG-1677 : Add ReflectionDiffBuilder.setExcludeFieldNames(...) and DiffExclude a…

2021-12-09 Thread GitBox
debae commented on pull request #838: URL: https://github.com/apache/commons-lang/pull/838#issuecomment-990193778 > Hi @debae Thank you for your patience. The code coverage for this new feature is not good enough IMO. Run `mvn clean site`, then browse the site in `target\site\index.html`,