[GitHub] [commons-lang] garydgregory commented on a change in pull request #784: [LANG-1593] Common behavior for StringUtils join APIs when called with char or String delimiter

garydgregory commented on a change in pull request #784: URL: https://github.com/apache/commons-lang/pull/784#discussion_r699367138 ## File path: src/test/java/org/apache/commons/lang3/StringUtilsTest.java ## @@ -1226,6 +1241,8 @@ public void testJoin_ArrayOfShorts() {

[GitHub] [commons-lang] garydgregory commented on a change in pull request #784: [LANG-1593] Common behavior for StringUtils join APIs when called with char or String delimiter

garydgregory commented on a change in pull request #784: URL: https://github.com/apache/commons-lang/pull/784#discussion_r699367138 ## File path: src/test/java/org/apache/commons/lang3/StringUtilsTest.java ## @@ -1226,6 +1241,8 @@ public void testJoin_ArrayOfShorts() {

[GitHub] [commons-lang] garydgregory commented on a change in pull request #784: [LANG-1593] Common behavior for StringUtils join APIs when called with char or String delimiter

garydgregory commented on a change in pull request #784: URL: https://github.com/apache/commons-lang/pull/784#discussion_r694850165 ## File path: src/test/java/org/apache/commons/lang3/StringUtilsTest.java ## @@ -1355,15 +1372,6 @@ public void testJoin_Objectarray() {

[GitHub] [commons-lang] garydgregory commented on a change in pull request #784: [LANG-1593] Common behavior for StringUtils join APIs when called with char or String delimiter

garydgregory commented on a change in pull request #784: URL: https://github.com/apache/commons-lang/pull/784#discussion_r694849198 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java ## @@ -4858,6 +5082,209 @@ public static String join(final short[] array, fi

[GitHub] [commons-lang] garydgregory commented on a change in pull request #784: [LANG-1593] Common behavior for StringUtils join APIs when called with char or String delimiter

garydgregory commented on a change in pull request #784: URL: https://github.com/apache/commons-lang/pull/784#discussion_r693335904 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java ## @@ -3922,6 +3922,37 @@ public static String join(final boolean[] array, f

[GitHub] [commons-lang] garydgregory commented on a change in pull request #784: [LANG-1593] Common behavior for StringUtils join APIs when called with char or String delimiter

garydgregory commented on a change in pull request #784: URL: https://github.com/apache/commons-lang/pull/784#discussion_r683017191 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java ## @@ -4858,6 +5127,38 @@ public static String join(final short[] array, fin

[GitHub] [commons-lang] garydgregory commented on a change in pull request #784: [LANG-1593] Common behavior for StringUtils join APIs when called with char or String delimiter

garydgregory commented on a change in pull request #784: URL: https://github.com/apache/commons-lang/pull/784#discussion_r683017853 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java ## @@ -4307,13 +4481,48 @@ public static String join(final int[] array, fina

[GitHub] [commons-lang] garydgregory commented on a change in pull request #784: [LANG-1593] Common behavior for StringUtils join APIs when called with char or String delimiter

garydgregory commented on a change in pull request #784: URL: https://github.com/apache/commons-lang/pull/784#discussion_r683017648 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java ## @@ -4818,13 +5052,48 @@ public static String join(final short[] array, fi

[GitHub] [commons-lang] garydgregory commented on a change in pull request #784: [LANG-1593] Common behavior for StringUtils join APIs when called with char or String delimiter

garydgregory commented on a change in pull request #784: URL: https://github.com/apache/commons-lang/pull/784#discussion_r683017414 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java ## @@ -4858,6 +5127,38 @@ public static String join(final short[] array, fin

[GitHub] [commons-lang] garydgregory commented on a change in pull request #784: [LANG-1593] Common behavior for StringUtils join APIs when called with char or String delimiter

garydgregory commented on a change in pull request #784: URL: https://github.com/apache/commons-lang/pull/784#discussion_r683017191 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java ## @@ -4858,6 +5127,38 @@ public static String join(final short[] array, fin