garydgregory commented on a change in pull request #815: URL: https://github.com/apache/commons-lang/pull/815#discussion_r730411096
########## File path: src/test/java/org/apache/commons/lang3/RangeTest.java ########## @@ -306,6 +306,7 @@ public void testIsOverlappedBy() { // easy inside range assertTrue(intRange.isOverlappedBy(Range.between(12, 18))); + assertTrue(intRange.isOverlappedBy(Range.between(5, 25))); Review comment: Hello @Rushi98 TY for your PR! This assert call was initially confusing to me because [5,25] is not the same kind of test as "easy inside range", it overlaps the _whole_ range, it is not _inside_ it like [12, 18] above it. To speed up the process, I've added a different test with a new comment in git master. Please verify and propose more if I think we are still missing a condition or use-case. TY! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org