[GitHub] [commons-lang] pixelr commented on pull request #583: [LANG-1544] Fixes null pointer exception in distance method in MethodUtils

2020-11-13 Thread GitBox
pixelr commented on pull request #583: URL: https://github.com/apache/commons-lang/pull/583#issuecomment-726595412 closing. Please re-open if need. Thanks for reviewing :) This is an automated message from the Apache Git Serv

[GitHub] [commons-lang] pixelr commented on pull request #583: [LANG-1544] Fixes null pointer exception in distance method in MethodUtils

2020-10-05 Thread GitBox
pixelr commented on pull request #583: URL: https://github.com/apache/commons-lang/pull/583#issuecomment-704019436 > Hi @pixelr > > After looking again, I'm not sure this PR makes sense. The test you patched calls a private method, and this private method is not going to be called w

[GitHub] [commons-lang] pixelr commented on pull request #583: [LANG-1544] Fixes null pointer exception in distance method in MethodUtils

2020-10-05 Thread GitBox
pixelr commented on pull request #583: URL: https://github.com/apache/commons-lang/pull/583#issuecomment-704019077 > Is there example user-side codes which can lead to NPE before this pr? @XenoAmess I took this a first good issue to fix. But, when I tried reproducing it, I am not abl