verhas commented on issue #461: Lang 1491
URL: https://github.com/apache/commons-lang/pull/461#issuecomment-539189787
I am sorry.
I had a discussion with my son, and he read this thread and gave me
feedback, that I accepted. I also edited my past comments to remove the parts
that I
verhas commented on issue #461: Lang 1491
URL: https://github.com/apache/commons-lang/pull/461#issuecomment-538752300
I do not see where you see in my words the lack of respect.
My change makes the code more compliant with Item 15 of Joshua Bloch
Effective Java, Third Edition
verhas commented on issue #461: Lang 1491
URL: https://github.com/apache/commons-lang/pull/461#issuecomment-538730441
>So I think it doesn't require us to remove them (i.e. everything will keep
working),
Somehow I have the strange feeling that you did not get the notion of the
verhas commented on issue #461: Lang 1491
URL: https://github.com/apache/commons-lang/pull/461#issuecomment-538700575
>Do you have a link to any JUnit 5 documentation supporting what you just
said, please?
https://junit.org/junit5/docs/current/user-guide/ says: "Test classes, test
verhas commented on issue #461: Lang 1491
URL: https://github.com/apache/commons-lang/pull/461#issuecomment-538671412
"I'm still more comfortable with JUnit 4."
If I were you I would not disclose that information in public. JUnit 5 was
released more than two years ago.
"But
verhas commented on issue #461: Lang 1491
URL: https://github.com/apache/commons-lang/pull/461#issuecomment-538670127
Why doesn't the project has a unique and generally followed style-guide that
governs questions like this.
You say that "if future PR's have tests that omit or use
