aherbert commented on pull request #99: URL: https://github.com/apache/commons-numbers/pull/99#issuecomment-864525537
If the array is null it is not the same result. Check the logic a few lines above. Please run the default maven goal before opening PRs so you can fix the build errors. On Sun, 20 Jun 2021, 10:21 Arturo Bernal, ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In > commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/FactorialDouble.java > <https://github.com/apache/commons-numbers/pull/99#discussion_r654905163>: > > > @@ -64,8 +64,8 @@ private FactorialDouble(int numValues, > } > > // Copy available values. > - for (int i = beginCopy; i < endCopy; i++) { > - factorialsDouble[i] = cache[i]; > + if (endCopy - 2 >= 0) { > > I think same result > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <https://github.com/apache/commons-numbers/pull/99#discussion_r654905163>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAGYMPWDOU7AAQZJC2FDDJ3TTWXINANCNFSM467YOTEQ> > . > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org