[GitHub] [commons-pool] aooohan commented on pull request #182: Avoid potential ConcurrentModificationException by using Iterator.

aooohan commented on PR #182: URL: https://github.com/apache/commons-pool/pull/182#issuecomment-1284790607 > You have not addressed my comment on why the locking already provided through synchronized blocks and synchronized methods is not enough For this, it's not a synchronization pr

[GitHub] [commons-pool] aooohan commented on pull request #182: Avoid potential ConcurrentModificationException by using Iterator.

aooohan commented on PR #182: URL: https://github.com/apache/commons-pool/pull/182#issuecomment-1284788430 > Then this PR won't make it because: > > * You cannot prove anything is wrong > * You have not addressed my comment on why the locking already provided through synchronized b

[GitHub] [commons-pool] aooohan commented on pull request #182: Avoid potential ConcurrentModificationException by using Iterator.

aooohan commented on PR #182: URL: https://github.com/apache/commons-pool/pull/182#issuecomment-1284072077 > We can wait until you update this PR with a failing test. It is somewhat difficult to verify this through unit tests, as there is nothing to assert and I think it is just a usage

[GitHub] [commons-pool] aooohan commented on pull request #182: Avoid potential ConcurrentModificationException by using Iterator.

aooohan commented on PR #182: URL: https://github.com/apache/commons-pool/pull/182#issuecomment-1283987610 Hi @garydgregory Sorry for the late reply. The following is unit test. ```java try (final GenericObjectPool pool = new GenericObjectPool<>(new BasePooledObj