[GitHub] [commons-pool] garydgregory commented on pull request #182: Avoid potential ConcurrentModificationException by using Iterator.

garydgregory commented on PR #182: URL: https://github.com/apache/commons-pool/pull/182#issuecomment-1284297988 Then this PR won't make it because: - You cannot prove anything is wrong - You have not addressed my comment on why the locking already provided through synchronized blocks a

[GitHub] [commons-pool] garydgregory commented on pull request #182: Avoid potential ConcurrentModificationException by using Iterator.

garydgregory commented on PR #182: URL: https://github.com/apache/commons-pool/pull/182#issuecomment-1284043771 Hi @aooohan Thank you for the update. We can wait until you update this PR with a failing test. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [commons-pool] garydgregory commented on pull request #182: Avoid potential ConcurrentModificationException by using Iterator.

garydgregory commented on PR #182: URL: https://github.com/apache/commons-pool/pull/182#issuecomment-1283783719 Hi @aooohan You'll need a unit test to prove this is a problem because the code appears to provide all the locking needed through synchronized blocks and methods. -- This is

[GitHub] [commons-pool] garydgregory commented on pull request #182: Avoid potential ConcurrentModificationException by using Iterator.

garydgregory commented on PR #182: URL: https://github.com/apache/commons-pool/pull/182#issuecomment-1278850860 This PR needs a unit test that fails without its main changes. Otherwise, it's just a regression waiting to happen. -- This is an automated message from the Apache Git Service.