[GitHub] [commons-pool] niallkp commented on pull request #199: [POOL-393] Improve BaseGenericObjectPool's JMX Register performance

2022-12-24 Thread GitBox
niallkp commented on PR #199: URL: https://github.com/apache/commons-pool/pull/199#issuecomment-1364561311 Firstly I would say that this PR doesn't change the logic of the method - it just checks first whether theres already a MBean with the same name rather than trying to register an MBea

[GitHub] [commons-pool] niallkp commented on pull request #199: [POOL-393] Improve BaseGenericObjectPool's JMX Register performance

2022-12-24 Thread GitBox
niallkp commented on PR #199: URL: https://github.com/apache/commons-pool/pull/199#issuecomment-1364536206 Sorry Gary, not sure what you mean about retries. When it retries it changes the name by incrementing the count - since the count is appended to the name of the MBean being registered.