wx930910 opened a new pull request #98: URL: https://github.com/apache/commons-pool/pull/98
Fixes [POOL-400](https://issues.apache.org/jira/browse/POOL-400) ### Description Replace test class [SingleObjectFactory](https://github.com/apache/commons-pool/blob/dbb4ca0bc969464f31435867a0800fc766f31068/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPoolFactoryCreateFailure.java#L38) by mocking object created by Mockito. <hr> ##### Key changed/added classes in this PR - Create mocking object to replace test subclass `SingleObjectFactory`, decouple test from production code. - Extract the AtomicBoolean attribute and use the extracted attribute in test case to check method `created()` invocation status. - Make test logic more clear by using method stub instead of method overriding. - Introduce Mockito dependency <hr> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
