[GitHub] [commons-text] garydgregory commented on pull request #281: [TEXT-211] TextStringBuilder.equals whatever the capacity is

2022-03-31 Thread GitBox
garydgregory commented on pull request #281: URL: https://github.com/apache/commons-text/pull/281#issuecomment-1084673484 https://issues.apache.org/jira/browse/TEXT-211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [commons-text] garydgregory commented on pull request #281: TEXT-211 - TextStringBuilder.equals whatever the capacity is

2022-03-31 Thread GitBox
garydgregory commented on pull request #281: URL: https://github.com/apache/commons-text/pull/281#issuecomment-1084527910 In theory, the build should fail, but not all Commons components are set up properly with Checkstyle, SpotBugs, and PMD. -- This is an automated message from the Apac

[GitHub] [commons-text] garydgregory commented on pull request #281: TEXT-211 - TextStringBuilder.equals whatever the capacity is

2022-03-28 Thread GitBox
garydgregory commented on pull request #281: URL: https://github.com/apache/commons-text/pull/281#issuecomment-1081088455 This patch cannot be applied manually due to trailing whitespace, please fix: ``` git apply \temp\281.diff /temp/281.diff:63: trailing whitespace. /temp/2

[GitHub] [commons-text] garydgregory commented on pull request #281: TEXT-211 - TextStringBuilder.equals whatever the capacity is

2021-11-03 Thread GitBox
garydgregory commented on pull request #281: URL: https://github.com/apache/commons-text/pull/281#issuecomment-958980765 Hi @sebx59 - What about also testing `hashCode()`? - The formatting looks messed up -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [commons-text] garydgregory commented on pull request #281: TEXT-211 - TextStringBuilder.equals whatever the capacity is

2021-11-03 Thread GitBox
garydgregory commented on pull request #281: URL: https://github.com/apache/commons-text/pull/281#issuecomment-958980765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [commons-text] garydgregory commented on pull request #281: TEXT-211 - TextStringBuilder.equals whatever the capacity is

2021-11-03 Thread GitBox
garydgregory commented on pull request #281: URL: https://github.com/apache/commons-text/pull/281#issuecomment-958980765 Hi @sebx59 - What about also testing `hashCode()`? - The formatting looks messed up -- This is an automated message from the Apache Git Service. To respond to th