[GitHub] [commons-text] kinow commented on pull request #233: A More Efficient Implementation for Calculating Size of Longest Common Subsequence

kinow commented on pull request #233: URL: https://github.com/apache/commons-text/pull/233#issuecomment-893866228 Rebased PR onto latest `master`. Diff in GH UI now showing only code added for this PR. Also amending commit now to include the JIRA ticket. -- This is an automated message f

[GitHub] [commons-text] kinow commented on pull request #233: A More Efficient Implementation for Calculating Size of Longest Common Subsequence

kinow commented on pull request #233: URL: https://github.com/apache/commons-text/pull/233#issuecomment-889565428 Thanks @ali-ghanbari I've approved the GH Actions job, and it should finish in a few minutes :crossed_fingers: I should be able to review it again this weekend. -- This is a

[GitHub] [commons-text] kinow commented on pull request #233: A More Efficient Implementation for Calculating Size of Longest Common Subsequence

kinow commented on pull request #233: URL: https://github.com/apache/commons-text/pull/233#issuecomment-889554847 >Side note: I did not foget your comments about whitespaces; it looks like my editor adds them automatically when I reformatted the code to adjust the indentation. I can rectif

[GitHub] [commons-text] kinow commented on pull request #233: A More Efficient Implementation for Calculating Size of Longest Common Subsequence

kinow commented on pull request #233: URL: https://github.com/apache/commons-text/pull/233#issuecomment-21752 > By the way, JMH Maven profile and the test code are ready; I can push that also. Brilliant! Thanks heaps for the super fast reply @ali-ghanbari ! -- This is an autom

[GitHub] [commons-text] kinow commented on pull request #233: A More Efficient Implementation for Calculating Size of Longest Common Subsequence

kinow commented on pull request #233: URL: https://github.com/apache/commons-text/pull/233#issuecomment-886503147 Do you mind squashing the commits too? Adding an extra commit to add JMH should be fine and doesn't need to be squashed if you don't want to, but if the next review doesn't fin

[GitHub] [commons-text] kinow commented on pull request #233: A More Efficient Implementation for Calculating Size of Longest Common Subsequence

kinow commented on pull request #233: URL: https://github.com/apache/commons-text/pull/233#issuecomment-886501203 @ali-ghanbari we are not releqsing 2.0 yet. That's why the method with a typo was not removed. Could you put it back, please? -- This is an automated message from the Apache

[GitHub] [commons-text] kinow commented on pull request #233: A More Efficient Implementation for Calculating Size of Longest Common Subsequence

kinow commented on pull request #233: URL: https://github.com/apache/commons-text/pull/233#issuecomment-886260831 I think I fixed the Javadoc error in `master`. If you could rebase it later, then CI should be OK again. BTW, when we are ready to merge it, if I am the one doing the merge, I

[GitHub] [commons-text] kinow commented on pull request #233: A More Efficient Implementation for Calculating Size of Longest Common Subsequence

kinow commented on pull request #233: URL: https://github.com/apache/commons-text/pull/233#issuecomment-886260131 There is already a JMH test somewhere in the code, added recently to Text (I was looking at Numbers & Imaging, as I recalled we added one somewhere really recently - turns out

[GitHub] [commons-text] kinow commented on pull request #233: A More Efficient Implementation for Calculating Size of Longest Common Subsequence

kinow commented on pull request #233: URL: https://github.com/apache/commons-text/pull/233#issuecomment-886258537 @ali-ghanbari , I will review it once I have some spare time. Thanks a lot for updating the PR and fixing CI issues. We can definitely ignore that issue since it is not b

[GitHub] [commons-text] kinow commented on pull request #233: A More Efficient Implementation for Calculating Size of Longest Common Subsequence

kinow commented on pull request #233: URL: https://github.com/apache/commons-text/pull/233#issuecomment-885937083 @ali-ghanbari >But if we want to keep Algorithm C, we must keep Algorithm B as it is being called from Algorithm C. And in that case (in my opinion) it is ideal to use

[GitHub] [commons-text] kinow commented on pull request #233: A More Efficient Implementation for Calculating Size of Longest Common Subsequence

kinow commented on pull request #233: URL: https://github.com/apache/commons-text/pull/233#issuecomment-881969525 Finished reviewing another PR for Commons Text, now this one is the next in the list. Sorry for the long wait @ali-ghanbari -- This is an automated message from the Apache G