[GitHub] [commons-vfs] MaxKellermann commented on pull request #154: Rework SoftRefFilesCache locking

2021-02-28 Thread GitBox
MaxKellermann commented on pull request #154: URL: https://github.com/apache/commons-vfs/pull/154#issuecomment-787464930 Rebased after #158 was merged, dropping its 4 commits. This is an automated message from the Apache Git

[GitHub] [commons-vfs] MaxKellermann commented on pull request #154: Rework SoftRefFilesCache locking

2021-02-06 Thread GitBox
MaxKellermann commented on pull request #154: URL: https://github.com/apache/commons-vfs/pull/154#issuecomment-774619672 > Loom will have to find a solution for it, anyway. I agree with that. I read that OpenJDK link, and my first thought was: this is a bad implementation if it makes

[GitHub] [commons-vfs] MaxKellermann commented on pull request #154: Rework SoftRefFilesCache locking

2021-02-06 Thread GitBox
MaxKellermann commented on pull request #154: URL: https://github.com/apache/commons-vfs/pull/154#issuecomment-774433274 > @MaxKellermann, @garydgregory what do you think if we break this PR into a few other smaller PR's, I think that would be easier to review, and grouping that way in cas

[GitHub] [commons-vfs] MaxKellermann commented on pull request #154: Rework SoftRefFilesCache locking

2021-02-05 Thread GitBox
MaxKellermann commented on pull request #154: URL: https://github.com/apache/commons-vfs/pull/154#issuecomment-774418907 > Given that the Loom project will likely have issues with `synchronized` in its first iterations What kind of problems are caused by `synchronized`? I'm not a Jav

[GitHub] [commons-vfs] MaxKellermann commented on pull request #154: Rework SoftRefFilesCache locking

2021-01-18 Thread GitBox
MaxKellermann commented on pull request #154: URL: https://github.com/apache/commons-vfs/pull/154#issuecomment-762236081 Rebased and fixed conflict because the meanwhile-merged commit 048d34d1e0de11c1ecf44efcae58a225cee1ea96 duplicates my commit "SoftRefFilesCache: remove unnecessary initi

[GitHub] [commons-vfs] MaxKellermann commented on pull request #154: Rework SoftRefFilesCache locking

2021-01-12 Thread GitBox
MaxKellermann commented on pull request #154: URL: https://github.com/apache/commons-vfs/pull/154#issuecomment-758862303 Rebased and added an extra commit removing the unnecessary initializer, as requested. (This initializer has been there before, I did not add it, and it has actually noth

[GitHub] [commons-vfs] MaxKellermann commented on pull request #154: Rework SoftRefFilesCache locking

2021-01-07 Thread GitBox
MaxKellermann commented on pull request #154: URL: https://github.com/apache/commons-vfs/pull/154#issuecomment-756130584 > You mention that there are bugs, ok. But what are they? At the very least we need a list so users can know if a new release addresses an issue they may have. Ea