MaxKellermann commented on PR #20:
URL: https://github.com/apache/commons-vfs/pull/20#issuecomment-1104656002
Pong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
MaxKellermann commented on pull request #20:
URL: https://github.com/apache/commons-vfs/pull/20#issuecomment-759062544
Phew, after many iterations, I think I have found a solution for
`HdfsFileObject`. That class was confusing and broken, and I think it's better
now - faster and thread-saf
MaxKellermann commented on pull request #20:
URL: https://github.com/apache/commons-vfs/pull/20#issuecomment-758923039
> BTW I always try to use a VFS manager single threaded, I am not completely
sure but most of the code looks like this was the intended use anyway :)
My employer has
MaxKellermann commented on pull request #20:
URL: https://github.com/apache/commons-vfs/pull/20#issuecomment-758895616
Unit test failures because the `HdfsFileObject` class is a big fuckup ... it
calls the internal method `doAttach()`, circumventing `attach()`, i.e. the base
class `Abstrac
MaxKellermann commented on pull request #20:
URL: https://github.com/apache/commons-vfs/pull/20#issuecomment-758872788
I added commits for fixing the obvious TOCTOU bugs in SFTP and HDFS. The
other provides look like they don't need to be fixed.
---
MaxKellermann commented on pull request #20:
URL: https://github.com/apache/commons-vfs/pull/20#issuecomment-756068383
Most are - but look at the confusing commit which added `synchronized` to
the FTP provider: cd9e19f8eb6de22a3a545064ab0e68254bd243a2
Without requiring providers to be th
MaxKellermann commented on pull request #20:
URL: https://github.com/apache/commons-vfs/pull/20#issuecomment-756054642
> I am not sure if all providers (especialyl external ones) are ready to
deal with concurrent invocation of the do method.
That would be a bug in those providers, wo
