[GitHub] commons-lang issue #279: Fraction debug printings

2017-09-21 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-lang/pull/279 I think what Gary meant is that that comment is harmless, and can be used by other developers that want/need to debug the code, and see what is going on. I've used it in some projects myself, to

[GitHub] commons-lang issue #279: Fraction debug printings

2017-07-22 Thread ameyjadiye
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-lang/pull/279 debugging can be much effectively done with IDE, adding these kind of console output is discouraged. I would recommend to use logging _logger.debug()_, but that's not the guidelines in

[GitHub] commons-lang issue #279: Fraction debug printings

2017-07-22 Thread mureinik
Github user mureinik commented on the issue: https://github.com/apache/commons-lang/pull/279 How is this code useful? It adds nothing to the functionality, nor does it help explain the code. It seems like the original author used it while developing this class, but once it's done, I

[GitHub] commons-lang issue #279: Fraction debug printings

2017-07-22 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/279 [![Coverage Status](https://coveralls.io/builds/12505545/badge)](https://coveralls.io/builds/12505545) Coverage remained the same at 95.167% when pulling