Github user rosti-il commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/392#discussion_r241744790
--- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java ---
@@ -338,15 +338,17 @@ public static boolean isAllEmpty(final
CharSequence... css
Github user asciborek commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/392#discussion_r241740720
--- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java ---
@@ -338,15 +338,17 @@ public static boolean isAllEmpty(final
CharSequence... cs
GitHub user rosti-il opened a pull request:
https://github.com/apache/commons-lang/pull/392
LANG-1410: eliminate one unnecessary local int variable and add more tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rosti-il/commo
GitHub user RahulNagekar reopened a pull request:
https://github.com/apache/commons-lang/pull/391
Adding junits for JsonToStringStyle
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/RahulNagekar/commons-lang
JsonToStringStyle_Ju
Github user RahulNagekar closed the pull request at:
https://github.com/apache/commons-lang/pull/391
---
GitHub user RahulNagekar opened a pull request:
https://github.com/apache/commons-lang/pull/391
Adding junits for JsonToStringStyle
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/RahulNagekar/commons-lang
JsonToStringStyle_Juni
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/390
---
Github user RahulNagekar commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/278#discussion_r238078898
--- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java ---
@@ -9008,6 +9011,56 @@ public static String appendIfMissingIgnoreCase(final
Github user asciborek closed the pull request at:
https://github.com/apache/commons-lang/pull/385
---
Github user RahulNagekar commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/278#discussion_r238055353
--- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java ---
@@ -9008,6 +9011,56 @@ public static String appendIfMissingIgnoreCase(final
Github user RahulNagekar commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/278#discussion_r238055373
--- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java ---
@@ -9008,6 +9011,56 @@ public static String appendIfMissingIgnoreCase(final
Github user RahulNagekar commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/278#discussion_r238055284
--- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java ---
@@ -9109,6 +9162,56 @@ public static String
prependIfMissingIgnoreCase(final
Github user RahulNagekar commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/278#discussion_r238055291
--- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java ---
@@ -9109,6 +9162,56 @@ public static String
prependIfMissingIgnoreCase(final
Github user RahulNagekar commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/278#discussion_r238054600
--- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java ---
@@ -9008,6 +9011,56 @@ public static String appendIfMissingIgnoreCase(final
Github user RahulNagekar commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/278#discussion_r238055393
--- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java ---
@@ -9109,6 +9162,56 @@ public static String
prependIfMissingIgnoreCase(final
Github user RahulNagekar commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/278#discussion_r238054555
--- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java ---
@@ -9008,6 +9011,56 @@ public static String appendIfMissingIgnoreCase(final
Github user RahulNagekar commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/278#discussion_r238055382
--- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java ---
@@ -9109,6 +9162,56 @@ public static String
prependIfMissingIgnoreCase(final
Github user RahulNagekar commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/278#discussion_r238054315
--- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java ---
@@ -9008,6 +9011,56 @@ public static String appendIfMissingIgnoreCase(final
GitHub user RahulNagekar opened a pull request:
https://github.com/apache/commons-lang/pull/390
Adding junits for StandardToStringStyle
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/RahulNagekar/commons-lang
StandardToStringSt
Github user RahulNagekar closed the pull request at:
https://github.com/apache/commons-lang/pull/389
---
GitHub user RahulNagekar opened a pull request:
https://github.com/apache/commons-lang/pull/389
(doc) StandardToStringStyle removing unnecessary method overrides
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/RahulNagekar/common
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/385#discussion_r236042692
--- Diff:
src/test/java/org/apache/commons/lang3/function/CheckedFunctionTest.java ---
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software F
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/384
---
GitHub user asciborek opened a pull request:
https://github.com/apache/commons-lang/pull/385
WIP: CheckedFunction utils
This is an example of utils which I would like to create. Purpose of
interfaces like this is to simplify usage of java streams
You can merge this pull request int
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-lang/pull/384
Travis: Stop building with Java 9 and 10, as these are superseded by â¦
â¦Java 11 and not supported anymore.
You can merge this pull request into a Git repository by running:
$
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/383
---
Github user harbby closed the pull request at:
https://github.com/apache/commons-lang/pull/345
---
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-lang/pull/383
Make whitespace use after tokens consistent and add checkstyle rule tâ¦
â¦o enforce it.
You can merge this pull request into a Git repository by running:
$ git pull https://git
Github user Turan91 commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/362#discussion_r234053572
--- Diff: src/test/java/org/apache/commons/lang3/StringUtilsTest.java ---
@@ -1592,6 +1592,12 @@ public void testRepeat_StringInt() {
final
GitHub user asciborek opened a pull request:
https://github.com/apache/commons-lang/pull/382
Proposal: Duration Utils - round value of the duration in a given unit
For instance, in case of duration equals 90 minuts, the method
roundHoursQuantity should return 2 (hours), and in case
Github user asciborek closed the pull request at:
https://github.com/apache/commons-lang/pull/377
---
GitHub user drajakumar opened a pull request:
https://github.com/apache/commons-lang/pull/381
LANG-1406 StringIndexOutOfBoundsException in StringUtils.replaceIgnorâ¦
â¦eCase
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/drajak
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/380
---
GitHub user oorijsonar opened a pull request:
https://github.com/apache/commons-lang/pull/380
fix javadoc typo
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/oorijsonar/commons-lang fix_javadoc_typo
Alternatively you can review
Github user apirom9 closed the pull request at:
https://github.com/apache/commons-lang/pull/378
---
GitHub user apirom9 opened a pull request:
https://github.com/apache/commons-lang/pull/379
add tests for use ImmutableTriple as key in java.util.HashMap and
java.util.TreeMap
add tests for use ImmutableTriple as key in java.util.HashMap and
java.util.TreeMap
You can merge this pul
GitHub user apirom9 opened a pull request:
https://github.com/apache/commons-lang/pull/378
add more test cases to use ImmutablePair class as key for java.util.HashMap
and java.utilâ¦
â¦.TreeMap
You can merge this pull request into a Git repository by running:
$ git pull http
Github user zmacomber commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/358#discussion_r228178951
--- Diff: src/main/java/org/apache/commons/lang3/ClassUtils.java ---
@@ -1059,6 +1067,62 @@ public static boolean isInnerClass(final Class
cls) {
Github user zmacomber commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/358#discussion_r228178841
--- Diff: src/main/java/org/apache/commons/lang3/ClassUtils.java ---
@@ -1059,6 +1067,62 @@ public static boolean isInnerClass(final Class
cls) {
Github user zmacomber commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/358#discussion_r228178901
--- Diff: src/main/java/org/apache/commons/lang3/ClassUtils.java ---
@@ -1059,6 +1067,62 @@ public static boolean isInnerClass(final Class
cls) {
Github user zmacomber commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/358#discussion_r228140306
--- Diff: src/main/java/org/apache/commons/lang3/ClassUtils.java ---
@@ -1059,6 +1067,62 @@ public static boolean isInnerClass(final Class
cls) {
Github user aaabramov commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/362#discussion_r226915778
--- Diff: src/test/java/org/apache/commons/lang3/StringUtilsTest.java ---
@@ -1592,6 +1592,12 @@ public void testRepeat_StringInt() {
fin
Github user aaabramov commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/358#discussion_r226900275
--- Diff: src/main/java/org/apache/commons/lang3/ClassUtils.java ---
@@ -1059,6 +1067,62 @@ public static boolean isInnerClass(final Class
cls) {
Github user aaabramov commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/358#discussion_r226900283
--- Diff: src/main/java/org/apache/commons/lang3/ClassUtils.java ---
@@ -1059,6 +1067,62 @@ public static boolean isInnerClass(final Class
cls) {
Github user aaabramov commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/358#discussion_r226899975
--- Diff: src/main/java/org/apache/commons/lang3/ClassUtils.java ---
@@ -1059,6 +1067,62 @@ public static boolean isInnerClass(final Class
cls) {
Github user aaabramov commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/358#discussion_r226900323
--- Diff: src/main/java/org/apache/commons/lang3/ClassUtils.java ---
@@ -1059,6 +1067,62 @@ public static boolean isInnerClass(final Class
cls) {
Github user zmacomber commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/358#discussion_r225537457
--- Diff: src/test/java/org/apache/commons/lang3/ClassUtilsTest.java ---
@@ -1202,6 +1206,56 @@ public void testGetInnerClass() throws
ClassNotFoundE
Github user zmacomber commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/358#discussion_r225537382
--- Diff: src/test/java/org/apache/commons/lang3/ClassUtilsTest.java ---
@@ -1202,6 +1206,56 @@ public void testGetInnerClass() throws
ClassNotFoundE
Github user zmacomber commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/358#discussion_r225522003
--- Diff: src/main/java/org/apache/commons/lang3/ClassUtils.java ---
@@ -1059,6 +1066,69 @@ public static boolean isInnerClass(final Class
cls) {
Github user zmacomber commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/358#discussion_r225509052
--- Diff: src/main/java/org/apache/commons/lang3/ClassUtils.java ---
@@ -1059,6 +1066,69 @@ public static boolean isInnerClass(final Class
cls) {
Github user zmacomber commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/358#discussion_r225508989
--- Diff: src/main/java/org/apache/commons/lang3/ClassUtils.java ---
@@ -1059,6 +1066,69 @@ public static boolean isInnerClass(final Class
cls) {
Github user zmacomber commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/358#discussion_r225508754
--- Diff: src/test/java/org/apache/commons/lang3/ClassUtilsTest.java ---
@@ -1202,6 +1206,56 @@ public void testGetInnerClass() throws
ClassNotFoundE
Github user zmacomber commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/358#discussion_r225508801
--- Diff: src/test/java/org/apache/commons/lang3/ClassUtilsTest.java ---
@@ -1202,6 +1206,56 @@ public void testGetInnerClass() throws
ClassNotFoundE
Github user grimreaper commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/358#discussion_r225309090
--- Diff: src/main/java/org/apache/commons/lang3/ClassUtils.java ---
@@ -1059,6 +1066,69 @@ public static boolean isInnerClass(final Class
cls) {
Github user zmacomber commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/358#discussion_r225283052
--- Diff: src/main/java/org/apache/commons/lang3/ClassUtils.java ---
@@ -1059,6 +1066,69 @@ public static boolean isInnerClass(final Class
cls) {
Github user zmacomber commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/358#discussion_r225282462
--- Diff: src/main/java/org/apache/commons/lang3/ClassUtils.java ---
@@ -1059,6 +1066,69 @@ public static boolean isInnerClass(final Class
cls) {
Github user sudeendra-nadager commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/358#discussion_r225264987
--- Diff: src/test/java/org/apache/commons/lang3/ClassUtilsTest.java ---
@@ -1202,6 +1206,56 @@ public void testGetInnerClass() throws
ClassN
Github user sudeendra-nadager commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/358#discussion_r225264946
--- Diff: src/test/java/org/apache/commons/lang3/ClassUtilsTest.java ---
@@ -1202,6 +1206,56 @@ public void testGetInnerClass() throws
ClassN
Github user sudeendra-nadager commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/358#discussion_r225264152
--- Diff: src/main/java/org/apache/commons/lang3/ClassUtils.java ---
@@ -1059,6 +1066,69 @@ public static boolean isInnerClass(final Class
cl
Github user sudeendra-nadager commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/358#discussion_r225263720
--- Diff: src/main/java/org/apache/commons/lang3/ClassUtils.java ---
@@ -1059,6 +1066,69 @@ public static boolean isInnerClass(final Class
cl
Github user sudeendra-nadager commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/358#discussion_r225263101
--- Diff: src/main/java/org/apache/commons/lang3/ClassUtils.java ---
@@ -1059,6 +1066,69 @@ public static boolean isInnerClass(final Class
cl
GitHub user asciborek opened a pull request:
https://github.com/apache/commons-lang/pull/377
LANG_1407 add DurationUtils
I've added an util class with methods for rounding duration
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/a
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/376
---
GitHub user mureinik opened a pull request:
https://github.com/apache/commons-lang/pull/376
Test cleanup
Following up after the migration of the test suite to JUnit Jupiter, some
test code could be cleaned up to make it clearer and easier to maintain.
This PR contains several pa
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/375
---
GitHub user mureinik opened a pull request:
https://github.com/apache/commons-lang/pull/375
JUnit Jupiter migration completion
This patch finalizes the upgrade of commons-lang's tests to use JUnit
Jupiter and removes the Vintage Engine dependency entirely.
While most of the
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/374
---
Github user mureinik commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/374#discussion_r224144394
--- Diff: pom.xml ---
@@ -543,6 +543,11 @@
junit-vintage-engine
test
+
+ org.junit-pioneer
+
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/374#discussion_r224137193
--- Diff: pom.xml ---
@@ -543,6 +543,11 @@
junit-vintage-engine
test
+
+ org.junit-pioneer
GitHub user mureinik opened a pull request:
https://github.com/apache/commons-lang/pull/374
Update time tests to JUnit Jupiter
Upgrade the tests in the `time` package to use JUnit Jupiter as part of the
effort to remove the dependency on the Vintage Engine.
While most of th
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/373
---
GitHub user mureinik opened a pull request:
https://github.com/apache/commons-lang/pull/373
Update mutable tests to JUnit Jupiter
Upgrade the tests in the `mutable` package to use JUnit Jupiter as part of
the effort to remove the dependency on the Vintage Engine.
While most
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/372
---
GitHub user mureinik opened a pull request:
https://github.com/apache/commons-lang/pull/372
Update math tests to JUnit Jupiter
Upgrade the tests in the `math` package to use JUnit Jupiter as part of the
effort to remove the dependency on the Vintage Engine.
While most of th
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/371
---
GitHub user mureinik opened a pull request:
https://github.com/apache/commons-lang/pull/371
Update tuple tests to JUnit Jupiter
Upgrade the tests in the text package to use JUnit Jupiter as part of the
effort to remove the dependency on the Vintage Engine.
You can merge this pull r
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/370
---
GitHub user mureinik opened a pull request:
https://github.com/apache/commons-lang/pull/370
Update text tests to JUnit Jupiter
Upgrade the tests in the `text` package to use JUnit Jupiter as part of the
effort to remove the dependency on the Vintage Engine.
While most of th
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/369
---
GitHub user mureinik opened a pull request:
https://github.com/apache/commons-lang/pull/369
Update reflect tests to JUnit Jupiter
Upgrade the tests in the `reflect` package to use JUnit Jupiter as part of
the effort to remove the dependency on the Vintage Engine.
While most
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/368
---
GitHub user mureinik opened a pull request:
https://github.com/apache/commons-lang/pull/368
Update exception tests to JUnit Jupiter
Upgrade the tests in the `exception` package to use JUnit Jupiter as part
of the effort to remove the dependency on the Vintage Engine.
While
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/367
---
GitHub user mureinik opened a pull request:
https://github.com/apache/commons-lang/pull/367
Update event tests to JUnit Jupiter
Upgrade the tests in the event package to use JUnit Jupiter as part of the
effort to remove the dependency on the Vintage Engine.
While most of th
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/366
---
GitHub user mureinik opened a pull request:
https://github.com/apache/commons-lang/pull/366
Update concurrent tests to JUnit Jupiter
Upgrade the tests in the concurrent package to use JUnit Jupiter as part of
the effort to remove the dependency on the Vintage Engine.
While
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/365
---
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-lang/pull/365
Travis: Also build with openjdk-ea
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PascalSchumacher/commons-lang
travis_openjdk_
Github user mureinik closed the pull request at:
https://github.com/apache/commons-lang/pull/363
---
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/359
---
Github user asciborek closed the pull request at:
https://github.com/apache/commons-lang/pull/364
---
GitHub user asciborek opened a pull request:
https://github.com/apache/commons-lang/pull/364
Lang 1407
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/asciborek/commons-lang LANG_1407
Alternatively you can review and apply these
Github user asciborek closed the pull request at:
https://github.com/apache/commons-lang/pull/360
---
GitHub user mureinik opened a pull request:
https://github.com/apache/commons-lang/pull/363
Update builder tests to JUnit Jupiter
Upgrade the tests in the builder package to use JUnit Jupiter as part of
the effort to remove the dependency on the Vintage Engine.
While most o
GitHub user Turan91 opened a pull request:
https://github.com/apache/commons-lang/pull/362
Add a check to StringUtils.repeat() for large length repeat value
I have added a check to ensure that the resultant String from the repeat is
not larger than the maximum allowed length.
You c
Github user Turan91 closed the pull request at:
https://github.com/apache/commons-lang/pull/361
---
GitHub user Turan91 opened a pull request:
https://github.com/apache/commons-lang/pull/361
Add check to StringUtils.repeat() for large length results
I have added a check to ensure that the resultant String is not larger than
the maximum allowed length.
You can merge this pull requ
GitHub user asciborek opened a pull request:
https://github.com/apache/commons-lang/pull/360
Lang 1407
I've added an utils class with methods to rounding Duration
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/asciborek/commons-l
Github user lploom commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/299#discussion_r221431119
--- Diff: src/main/java/module-info.java ---
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
GitHub user fanofxiaofeng opened a pull request:
https://github.com/apache/commons-lang/pull/359
these 2 links seem to be broken
These 2 links seem to be broken, just fix them~
