Re: [PR] [IO-808] Report problems in the file system as IOExceptions [commons-io]

2024-05-19 Thread via GitHub
elharo commented on PR #586: URL: https://github.com/apache/commons-io/pull/586#issuecomment-2119387508 The "policy" is set by the design of Java since 1.0. The current approach fights against how exceptions were designed to work in Java. Sure, you can do it that way and it compiles and per

Re: [PR] [IO-808] Report problems in the file system as IOExceptions [commons-io]

2024-05-19 Thread via GitHub
jochenw commented on PR #586: URL: https://github.com/apache/commons-io/pull/586#issuecomment-2119218511 Quoting @elharo: "A file that does not exist is not an illegal or inappropriate argument. " That is, in my opinion, a matter of policy, hence questionable. My personal opini

Re: [PR] [IO-808] Report problems in the file system as IOExceptions [commons-io]

2024-05-19 Thread via GitHub
elharo commented on PR #586: URL: https://github.com/apache/commons-io/pull/586#issuecomment-2119203043 When the problem is detected a core difference between runtime and checked exceptions. Runtime exceptions indicate program bugs, like passing the wrong argument. Checked exceptions indica

Re: [PR] [IO-808] Report problems in the file system as IOExceptions [commons-io]

2024-05-17 Thread via GitHub
garydgregory closed pull request #586: [IO-808] Report problems in the file system as IOExceptions URL: https://github.com/apache/commons-io/pull/586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [IO-808] Report problems in the file system as IOExceptions [commons-io]

2024-05-17 Thread via GitHub
garydgregory commented on PR #586: URL: https://github.com/apache/commons-io/pull/586#issuecomment-2117641475 Closing, I agree with @jochenw . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [IO-808] Report problems in the file system as IOExceptions [commons-io]

2024-05-17 Thread via GitHub
jochenw commented on PR #586: URL: https://github.com/apache/commons-io/pull/586#issuecomment-2117451928 Quoting from the Javadoc of IllegalArgumentException: "Thrown to indicate that a method has been passed an illegal or inappropriate argument." In other words, throwing an IAE is pe

[PR] [IO-808] Report problems in the file system as IOExceptions [commons-io]

2024-02-08 Thread via GitHub
elharo opened a new pull request, #586: URL: https://github.com/apache/commons-io/pull/586 Problems that can't be determined from the argument alone, that is problems that aren't detected until the file system is read, are IOExceptions, not program bugs represented by IllegalArgumentExcepti