garydgregory merged PR #402:
URL: https://github.com/apache/commons-collections/pull/402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
aherbert commented on PR #402:
URL:
https://github.com/apache/commons-collections/pull/402#issuecomment-1867945685
I previously requested Claude to remove some commented out code in a test
class. Otherwise this is fine.
--
This is an automated message from the Apache Git Service.
To
garydgregory commented on PR #402:
URL:
https://github.com/apache/commons-collections/pull/402#issuecomment-1867721330
@aherbert @Claudenw
Is this PR ready to merge? If not, what remains? TY!
--
This is an automated message from the Apache Git Service.
To respond to the message,
aherbert commented on code in PR #402:
URL:
https://github.com/apache/commons-collections/pull/402#discussion_r1423851680
##
src/test/java/org/apache/commons/collections4/bloomfilter/CountingPredicateTest.java:
##
@@ -28,11 +28,11 @@
import org.junit.jupiter.api.Test;
Claudenw commented on code in PR #402:
URL:
https://github.com/apache/commons-collections/pull/402#discussion_r1406448257
##
src/test/java/org/apache/commons/collections4/bloomfilter/CountingPredicateTest.java:
##
@@ -16,31 +16,103 @@
*/
package
aherbert commented on code in PR #402:
URL:
https://github.com/apache/commons-collections/pull/402#discussion_r1404661158
##
src/test/java/org/apache/commons/collections4/bloomfilter/CountingPredicateTest.java:
##
@@ -16,31 +16,103 @@
*/
package
Claudenw commented on PR #402:
URL:
https://github.com/apache/commons-collections/pull/402#issuecomment-1825804075
@aherbert just a friendly ping. I'd like to get this closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Claudenw commented on code in PR #402:
URL:
https://github.com/apache/commons-collections/pull/402#discussion_r1374723680
##
src/test/java/org/apache/commons/collections4/bloomfilter/CountingPredicateTest.java:
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software
Claudenw commented on code in PR #402:
URL:
https://github.com/apache/commons-collections/pull/402#discussion_r1374716969
##
src/test/java/org/apache/commons/collections4/bloomfilter/LayerManagerTest.java:
##
@@ -0,0 +1,305 @@
+/*
+ * Licensed to the Apache Software Foundation
Claudenw commented on code in PR #402:
URL:
https://github.com/apache/commons-collections/pull/402#discussion_r1374707288
##
src/test/java/org/apache/commons/collections4/bloomfilter/SimpleBloomFilterTest.java:
##
@@ -41,4 +41,16 @@ public void testMergeShortBitMapProducer() {
Claudenw commented on code in PR #402:
URL:
https://github.com/apache/commons-collections/pull/402#discussion_r1374706879
##
src/test/java/org/apache/commons/collections4/bloomfilter/WrappedBloomFilterTest.java:
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software
Claudenw commented on code in PR #402:
URL:
https://github.com/apache/commons-collections/pull/402#discussion_r1373701118
##
src/test/java/org/apache/commons/collections4/bloomfilter/LayerManagerTest.java:
##
@@ -0,0 +1,305 @@
+/*
+ * Licensed to the Apache Software Foundation
Claudenw commented on code in PR #402:
URL:
https://github.com/apache/commons-collections/pull/402#discussion_r1373696334
##
src/test/java/org/apache/commons/collections4/bloomfilter/LayerManagerTest.java:
##
@@ -0,0 +1,305 @@
+/*
+ * Licensed to the Apache Software Foundation
Claudenw commented on code in PR #402:
URL:
https://github.com/apache/commons-collections/pull/402#discussion_r1373190375
##
src/test/java/org/apache/commons/collections4/bloomfilter/DefaultBloomFilterTest.java:
##
@@ -215,9 +215,12 @@ public int cardinality() {
}
garydgregory commented on PR #402:
URL:
https://github.com/apache/commons-collections/pull/402#issuecomment-1773835199
> There are some changes to make to the test code. I only reviewed this
yesterday.
TY for the update
--
This is an automated message from the Apache Git
aherbert commented on PR #402:
URL:
https://github.com/apache/commons-collections/pull/402#issuecomment-1773833833
There are some changes to make to the test code. I only reviewed this
yesterday.
--
This is an automated message from the Apache Git Service.
To respond to the message,
garydgregory commented on PR #402:
URL:
https://github.com/apache/commons-collections/pull/402#issuecomment-1773814726
Hi All. Is this PR ready to be merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
aherbert commented on code in PR #402:
URL:
https://github.com/apache/commons-collections/pull/402#discussion_r1367387262
##
src/test/java/org/apache/commons/collections4/bloomfilter/CountingPredicateTest.java:
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software
Claudenw commented on PR #402:
URL:
https://github.com/apache/commons-collections/pull/402#issuecomment-1752110652
@aherbert Have you had a chance to look at the test code? I have a series
of blog posts about Bloom filters coming out "soon" (depending on when my
company gets around to
19 matches
Mail list logo
