Re: [PR] Guard DefaultExpressionEngineSymbols against empty builder [commons-configuration]

2024-03-17 Thread via GitHub
pingpingy1 commented on PR #382: URL: https://github.com/apache/commons-configuration/pull/382#issuecomment-2002914638 @garydgregory Yeah, I totally misunderstood how `null` delimiters were used in other parts of the program. Let me close this PR. Sorry for the trouble. -- This is an

Re: [PR] Guard DefaultExpressionEngineSymbols against empty builder [commons-configuration]

2024-03-17 Thread via GitHub
pingpingy1 closed pull request #382: Guard DefaultExpressionEngineSymbols against empty builder URL: https://github.com/apache/commons-configuration/pull/382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Guard DefaultExpressionEngineSymbols against empty builder [commons-configuration]

2024-03-17 Thread via GitHub
garydgregory commented on PR #382: URL: https://github.com/apache/commons-configuration/pull/382#issuecomment-2002471829 @pingpingy1 Please address my comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Guard DefaultExpressionEngineSymbols against empty builder [commons-configuration]

2024-03-15 Thread via GitHub
garydgregory commented on PR #382: URL: https://github.com/apache/commons-configuration/pull/382#issuecomment-1999551723 @pingpingy1 This PR breaks the build: ``` Error: Failures: Error: TestDefaultConfigurationKey.testAppendDelimitersWithoutEscaping:134 expected: but

[PR] Guard DefaultExpressionEngineSymbols against empty builder [commons-configuration]

2024-03-14 Thread via GitHub
pingpingy1 opened a new pull request, #382: URL: https://github.com/apache/commons-configuration/pull/382 If the symbols provided to the `DefaultExpressionEngineSymbols` is `null`, then they are saved to the respective `private final` properties, which is bound to throw an NPE at a later