Re: [PR] Improve JavaDoc for toStringArray methods [commons-lang]

ppkarwasz commented on PR #1417: URL: https://github.com/apache/commons-lang/pull/1417#issuecomment-3094727523 @Naveenkumarsuk, Thank you for your contribution and for engaging constructively throughout the review process. While your intention to improve the documentation is ap

Re: [PR] Improve JavaDoc for toStringArray methods [commons-lang]

ppkarwasz closed pull request #1417: Improve JavaDoc for toStringArray methods URL: https://github.com/apache/commons-lang/pull/1417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Improve JavaDoc for toStringArray methods [commons-lang]

garydgregory commented on code in PR #1417: URL: https://github.com/apache/commons-lang/pull/1417#discussion_r2217892944 ## src/main/java/org/apache/commons/lang3/ArrayUtils.java: ## @@ -9525,42 +9525,43 @@ public static String toString(final Object array, final String stringIf

Re: [PR] Improve JavaDoc for toStringArray methods [commons-lang]

ppkarwasz commented on code in PR #1417: URL: https://github.com/apache/commons-lang/pull/1417#discussion_r2217886061 ## src/main/java/org/apache/commons/lang3/ArrayUtils.java: ## @@ -9525,42 +9525,43 @@ public static String toString(final Object array, final String stringIfNul

Re: [PR] Improve JavaDoc for toStringArray methods [commons-lang]

ppkarwasz commented on PR #1417: URL: https://github.com/apache/commons-lang/pull/1417#issuecomment-3094629632 @Naveenkumarsuk, you didn't push any new commits to your PR branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Improve JavaDoc for toStringArray methods [commons-lang]

Naveenkumarsuk commented on PR #1417: URL: https://github.com/apache/commons-lang/pull/1417#issuecomment-3094628604 @ppkarwasz I've updated the JavaDocs as requested. Please close the PR if it still fails. I am working also for my own Startup and few other projects and I am interested in co

Re: [PR] Improve JavaDoc for toStringArray methods [commons-lang]

Naveenkumarsuk commented on PR #1417: URL: https://github.com/apache/commons-lang/pull/1417#issuecomment-3094584987 @ppkarwasz Thank Just to be fully transparent I did use GitHub Copilot to assist with this contribution, mainly for generating initial drafts of Javadoc and code stru

Re: [PR] Improve JavaDoc for toStringArray methods [commons-lang]

ppkarwasz commented on PR #1417: URL: https://github.com/apache/commons-lang/pull/1417#issuecomment-3094526782 @garydgregory, Since I use AI too for many **non-critical** tasks (e.g. generate some documentation without wasting my time), I am not so adamant against AI-generated conten

Re: [PR] Improve JavaDoc for toStringArray methods [commons-lang]

garydgregory commented on PR #1417: URL: https://github.com/apache/commons-lang/pull/1417#issuecomment-3094518829 The fact that two maintainers are cycling on this is a very bad sign IMO. We should close this PR and if you feel the Javadoc can be improved, you can just do it. -- This is

Re: [PR] Improve JavaDoc for toStringArray methods [commons-lang]

ppkarwasz commented on PR #1417: URL: https://github.com/apache/commons-lang/pull/1417#issuecomment-3094497256 > This makes the docs worse with random looking changes. Is this from a bot? The lack of indentation suggests that Copilot was involved somewhere in the process: I don't know

Re: [PR] Improve JavaDoc for toStringArray methods [commons-lang]

garydgregory commented on PR #1417: URL: https://github.com/apache/commons-lang/pull/1417#issuecomment-3094481432 This makes the docs worse with random looking changes. Is this from a bot? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Improve JavaDoc for toStringArray methods [commons-lang]

ppkarwasz commented on code in PR #1417: URL: https://github.com/apache/commons-lang/pull/1417#discussion_r2217720142 ## src/main/java/org/apache/commons/lang3/ArrayUtils.java: ## @@ -9526,32 +9526,30 @@ public static String toString(final Object array, final String stringIfNul

Re: [PR] Improve JavaDoc for toStringArray methods [commons-lang]

Naveenkumarsuk commented on PR #1417: URL: https://github.com/apache/commons-lang/pull/1417#issuecomment-3094357802 Hi @ppkarwasz Thanks again for the detailed feedback. I've updated the Javadoc as suggested: Restored clear null-handling info in both summary and tags Closed all ta

Re: [PR] Improve JavaDoc for toStringArray methods [commons-lang]

ppkarwasz commented on code in PR #1417: URL: https://github.com/apache/commons-lang/pull/1417#discussion_r2217678519 ## src/main/java/org/apache/commons/lang3/ArrayUtils.java: ## @@ -9526,32 +9526,28 @@ public static String toString(final Object array, final String stringIfNul

Re: [PR] Improve JavaDoc for toStringArray methods [commons-lang]

ppkarwasz commented on code in PR #1417: URL: https://github.com/apache/commons-lang/pull/1417#discussion_r2217659031 ## src/main/java/org/apache/commons/lang3/ArrayUtils.java: ## @@ -9526,32 +9526,28 @@ public static String toString(final Object array, final String stringIfNul

Re: [PR] Improve JavaDoc for toStringArray methods [commons-lang]

Copilot commented on code in PR #1417: URL: https://github.com/apache/commons-lang/pull/1417#discussion_r2217664482 ## src/main/java/org/apache/commons/lang3/ArrayUtils.java: ## @@ -9526,32 +9526,28 @@ public static String toString(final Object array, final String stringIfNull)

[PR] Improve JavaDoc for toStringArray methods [commons-lang]

Naveenkumarsuk opened a new pull request, #1417: URL: https://github.com/apache/commons-lang/pull/1417 Updated JavaDoc for both overloaded toStringArray methods in ArrayUtils.java to be clearer and more consistent. This improves readability and clarity for developers using these methods.