Re: [PR] Support for loom [commons-pool]

2024-05-22 Thread via GitHub
Fenrur commented on PR #230: URL: https://github.com/apache/commons-pool/pull/230#issuecomment-2126198637 Hello no news for this PR ? I also need this feature, I use apache polls with virtual threads -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] Support for loom [commons-pool]

2024-03-21 Thread via GitHub
wyhasany commented on code in PR #230: URL: https://github.com/apache/commons-pool/pull/230#discussion_r1533668593 ## src/main/java/org/apache/commons/pool3/impl/BaseGenericObjectPool.java: ## @@ -1617,7 +1624,8 @@ public final void setTestWhileIdle(final boolean testWhileIdle)

Re: [PR] Support for loom [commons-pool]

2024-03-20 Thread via GitHub
zenghu1chen commented on code in PR #230: URL: https://github.com/apache/commons-pool/pull/230#discussion_r1533291875 ## src/main/java/org/apache/commons/pool3/impl/BaseGenericObjectPool.java: ## @@ -1617,7 +1624,8 @@ public final void setTestWhileIdle(final boolean testWhileId

Re: [PR] Support for loom [commons-pool]

2024-03-20 Thread via GitHub
wyhasany commented on code in PR #230: URL: https://github.com/apache/commons-pool/pull/230#discussion_r1532175327 ## src/main/java/org/apache/commons/pool3/impl/BaseGenericObjectPool.java: ## @@ -1617,7 +1624,8 @@ public final void setTestWhileIdle(final boolean testWhileIdle)

Re: [PR] Support for loom [commons-pool]

2024-03-20 Thread via GitHub
wyhasany commented on PR #230: URL: https://github.com/apache/commons-pool/pull/230#issuecomment-2009729140 @psteitz / @zenghu1chen please take a look on my code review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Support for loom [commons-pool]

2024-02-26 Thread via GitHub
zenghu1chen commented on PR #230: URL: https://github.com/apache/commons-pool/pull/230#issuecomment-1965954534 @psteitz Thank you for your suggestion. I have already resubmitted the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Support for loom [commons-pool]

2024-01-18 Thread via GitHub
psteitz commented on PR #230: URL: https://github.com/apache/commons-pool/pull/230#issuecomment-1899325662 Returning back to this, I think we should eliminate the use of intrinsic locks here. The example is a little strange, but I can imagine other scenarios where pinning happens due to th