garydgregory merged PR #217:
URL: https://github.com/apache/commons-validator/pull/217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
homebeaver commented on code in PR #217:
URL: https://github.com/apache/commons-validator/pull/217#discussion_r1591470221
##
src/test/java/org/apache/commons/validator/routines/checkdigit/AbstractCheckDigitTest.java:
##
@@ -154,7 +154,11 @@ public void testCalculateInvalid() {
homebeaver commented on PR #217:
URL:
https://github.com/apache/commons-validator/pull/217#issuecomment-2096673914
> OK, then please add a test for that, something like `testMinimum()`, and
the whatever the max value is (if there is one, if not something that looks
very large).
Boun
garydgregory commented on code in PR #217:
URL: https://github.com/apache/commons-validator/pull/217#discussion_r1591128203
##
src/test/java/org/apache/commons/validator/routines/checkdigit/AbstractCheckDigitTest.java:
##
@@ -154,7 +154,11 @@ public void testCalculateInvalid() {
garydgregory commented on PR #217:
URL:
https://github.com/apache/commons-validator/pull/217#issuecomment-2096227738
> The theoretical MIN valid EC-Number is 000-001-6;
OK, then please add a test for that, something like `testMinimum()`, and the
whatever the max value is (if there is
homebeaver commented on PR #217:
URL:
https://github.com/apache/commons-validator/pull/217#issuecomment-2096067917
> ...I don't see tests that make sure _invalid_ input is in fact invalid.
For example, when the check digit is incorrect.
@garydgregory
Test `AbstractCheckDigitT
garydgregory commented on code in PR #217:
URL: https://github.com/apache/commons-validator/pull/217#discussion_r1590936802
##
src/main/java/org/apache/commons/validator/routines/checkdigit/ModulusCheckDigit.java:
##
@@ -185,6 +185,16 @@ protected int toInt(final char character,
homebeaver opened a new pull request, #217:
URL: https://github.com/apache/commons-validator/pull/217
Hi @garydgregory
I incidently closed PR #216 - so I open a new one. Your hints from
yesterday are done with last two commits.
Same description:
CASNumberCheckDigit - CAS
homebeaver closed pull request #216: Validator CASNumberCheckDigit for Chemical
Registry CAS Numbers and ECNumberCheckDigit
URL: https://github.com/apache/commons-validator/pull/216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
garydgregory commented on code in PR #216:
URL: https://github.com/apache/commons-validator/pull/216#discussion_r1590324152
##
src/main/java/org/apache/commons/validator/routines/checkdigit/CASNumberCheckDigit.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Fo
homebeaver commented on PR #216:
URL:
https://github.com/apache/commons-validator/pull/216#issuecomment-2094706124
> ... see my comments.
Tkx for hints @garydgregory - Changes done - regards
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
garydgregory commented on code in PR #216:
URL: https://github.com/apache/commons-validator/pull/216#discussion_r1590003430
##
src/main/java/org/apache/commons/validator/routines/checkdigit/ECNumberCheckDigit.java:
##
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache Software Fou
homebeaver opened a new pull request, #216:
URL: https://github.com/apache/commons-validator/pull/216
CASNumberCheckDigit - CAS Chemical Abstracts Service RN Registry No
CAS Numbers are unique identification numbers used to identify chemical
substance described in the open scientifi
13 matches
Mail list logo
