[ https://issues.apache.org/jira/browse/POOL-244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phil Steitz closed POOL-244. ---------------------------- > [PATCH] Add more tests to [pool] > -------------------------------- > > Key: POOL-244 > URL: https://issues.apache.org/jira/browse/POOL-244 > Project: Commons Pool > Issue Type: Test > Reporter: Bruno P. Kinoshita > Priority: Trivial > Labels: coverage, patch, tests > Fix For: 2.1 > > Attachments: POOL-244.patch > > > Hi! > I read a new version of [pool] was being prepared to be released and decided > to chime in and add a few more tests. > With these new tests, I believe the line coverage is above 70% is almost all > the inner/classes but one that I thought wasn't worth writing more tests. > In future dev cycles I hope to be able to increase the branch coverage to > somewhere near 70% too, as well as fix some of the TODO tasks in the test > code. > I found a few trivial things that could be changed I think (typos, > unreachable if's and naming inconsistencies) but I'll create separate issues > for each one. > Please, feel free to massage the code as much as needed or drop any parts if > needed. > Hope that helps, > Bruno -- This message was sent by Atlassian JIRA (v6.3.4#6332)