[
https://issues.apache.org/jira/browse/CHAIN-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422943#comment-13422943
]
Simone Tripodi commented on CHAIN-72:
-------------------------------------
Hi Elijah,
thanks a lot for the hard work, I am happy you got committed to the project :)
I have few observations:
* I didn't see the benefit of having the NOP impl - while in the logging world
it makes a lot of sense - just mute logging, without altering the software
behavior - in the parsing world would mean that doesn't build anything the
client expects instead. What did I miss? Maybe the NOP module are just APIs? In
that case, I would be rename the module in configuration-api. WDYT?
* avoid {{Class.forName()}} but rather use {{ClassLoader.loadClass()}} - that
would help issues when parser and target classes are defined in different
ClassLoaders;
* last, but not least: don't commit IDEA *.iml files, but rather add them the
svn:ignore property
Once addressed my questions, I think you could start checkin it the code.
TIA!
> configuration façade APIs
> -------------------------
>
> Key: CHAIN-72
> URL: https://issues.apache.org/jira/browse/CHAIN-72
> Project: Commons Chain
> Issue Type: New Feature
> Affects Versions: 2.0
> Reporter: Simone Tripodi
> Assignee: Elijah Zupancic
> Fix For: 2.0
>
> Attachments: chain-72.diff
>
>
> As discussed in ML, define a façade API for textual configurations and rename
> the current XML configuration module to xml-configuration (and adapt it to
> new APIs)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
