[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15038790#comment-15038790
]
Ryan Blue commented on CODEC-125:
-
For anyone trying to track down the license for the Beider-Morse module,
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13083179#comment-13083179
]
Matthew Pocock commented on CODEC-125:
--
The lucene/solr source seems not to reference
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13083198#comment-13083198
]
Sebb commented on CODEC-125:
Changing API means more than a version bump; for Commons it
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13083402#comment-13083402
]
Gary D. Gregory commented on CODEC-125:
---
Hi Matthew, Sebb, and all:
The next release
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13083416#comment-13083416
]
Matthew Pocock commented on CODEC-125:
--
hashSet.toString isn't deterministic between
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13083428#comment-13083428
]
Sebb commented on CODEC-125:
@Gary. If there is already a need to break compat., then I don't
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13083432#comment-13083432
]
Gary D. Gregory commented on CODEC-125:
---
BUT... BM is a *new* codec for 2.0.
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13083501#comment-13083501
]
Sebb commented on CODEC-125:
@Gary: yes, I know it's new; my concern is about the next release
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13082617#comment-13082617
]
Matthew Pocock commented on CODEC-125:
--
Gary and I where talking about altering the
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13082643#comment-13082643
]
Gary D. Gregory commented on CODEC-125:
---
I hope it does not matter unless the call
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13080943#comment-13080943
]
Matthew Pocock commented on CODEC-125:
--
Hi,
* Would not it make sense to add surnames
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13080973#comment-13080973
]
Gary D. Gregory commented on CODEC-125:
---
Added
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13080974#comment-13080974
]
Gary D. Gregory commented on CODEC-125:
---
Note that an another memory improvement
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13081106#comment-13081106
]
Matthew Pocock commented on CODEC-125:
--
After turning off all the 'helpful' filters,
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13081210#comment-13081210
]
Matthew Pocock commented on CODEC-125:
--
Gary and I have found that the last patch did
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13081270#comment-13081270
]
Gary D. Gregory commented on CODEC-125:
---
Patch applied. Thank you! Discussing another
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13081360#comment-13081360
]
Gary D. Gregory commented on CODEC-125:
---
Patch applied:
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13080586#comment-13080586
]
Tamas Kende commented on CODEC-125:
---
Matthew:
I have some questions/observations about
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13080596#comment-13080596
]
Gary D. Gregory commented on CODEC-125:
---
An interesting issue I see is that the
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13080614#comment-13080614
]
Gary D. Gregory commented on CODEC-125:
---
Tamas, can you try again with the latest
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13080619#comment-13080619
]
Tamas Kende commented on CODEC-125:
---
Still too much deviation. It's completed in 1.3 and
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13080623#comment-13080623
]
Gary D. Gregory commented on CODEC-125:
---
Wow. This must be due to lots of objects
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13080627#comment-13080627
]
Gary D. Gregory commented on CODEC-125:
---
Tamas, any chance you can provide unit test
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13080667#comment-13080667
]
Tamas Kende commented on CODEC-125:
---
I will try, but I have problems with the original
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13080405#comment-13080405
]
Matthew Pocock commented on CODEC-125:
--
The d'ortley test input string exercises this
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13080423#comment-13080423
]
Gary D. Gregory commented on CODEC-125:
---
Patch applied:
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13080022#comment-13080022
]
Gary D. Gregory commented on CODEC-125:
---
Patch applied, thank you.
Implement a
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13080332#comment-13080332
]
Gary D. Gregory commented on CODEC-125:
---
Patch applied. Thank you Matthew. I am
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13080334#comment-13080334
]
Gary D. Gregory commented on CODEC-125:
---
Matthew:
Is this comment in PhoneticEngine
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13079427#comment-13079427
]
Gary D. Gregory commented on CODEC-125:
---
Any chance of getting more tests? Matthew?
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13079457#comment-13079457
]
Tamas Kende commented on CODEC-125:
---
Gary:
I would like to, but I am busy now. I will try
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13073380#comment-13073380
]
Tamas Kende commented on CODEC-125:
---
Matthew:
Sorry I forget to write down how did I
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13073383#comment-13073383
]
Matthew Pocock commented on CODEC-125:
--
Tamas,
We can add Ignácz, Ignátz and Ignác as
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13073397#comment-13073397
]
Gary D. Gregory commented on CODEC-125:
---
Patch applied for
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13072285#comment-13072285
]
Matthew Pocock commented on CODEC-125:
--
=The code coverage shows some code untouched,
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13072356#comment-13072356
]
Gary D. Gregory commented on CODEC-125:
---
Ok, it sounds like you have a plan. I'll
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13072366#comment-13072366
]
Gary D. Gregory commented on CODEC-125:
---
Matthew: Why not make the encoder reply be a
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13072496#comment-13072496
]
Tamas Kende commented on CODEC-125:
---
Matthew:
I started to compare the results of the php
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13072608#comment-13072608
]
Matthew Pocock commented on CODEC-125:
--
Gary: I was following what the PHP returned.
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13072609#comment-13072609
]
Matthew Pocock commented on CODEC-125:
--
Tamas: This looks like a bug in my
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13071566#comment-13071566
]
tester commented on CODEC-125:
--
I think I've found something:
the method encode throws an
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13071586#comment-13071586
]
Tamas Kende commented on CODEC-125:
---
Hi all,
I found a performance issue (maybe it is
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13071893#comment-13071893
]
Gary D. Gregory commented on CODEC-125:
---
I hope Matthew can fix this but here is what
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13072159#comment-13072159
]
Gary D. Gregory commented on CODEC-125:
---
Patch applied with very minor mods. Thank
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13071030#comment-13071030
]
Matthew Pocock commented on CODEC-125:
--
Hi Sebb,
I could not see any way in a patch
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13071057#comment-13071057
]
Sebb commented on CODEC-125:
svn:mime-type property can be used to specify the encoding, but in
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13071232#comment-13071232
]
Gary D. Gregory commented on CODEC-125:
---
Matthew and I had a debugging session and I
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13071357#comment-13071357
]
Gary D. Gregory commented on CODEC-125:
---
Did a little bit of cleaning up today,
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13071492#comment-13071492
]
Gary D. Gregory commented on CODEC-125:
---
A quick note to let you know that
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13071493#comment-13071493
]
Gary D. Gregory commented on CODEC-125:
---
TODOs from FindBugs:
Method
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13070559#comment-13070559
]
Gary D. Gregory commented on CODEC-125:
---
For me it looks like this test:
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13070634#comment-13070634
]
Sebb commented on CODEC-125:
Works OK for me with Java 1.5 and Java 1.6.
Perhaps you could
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13070664#comment-13070664
]
Sebb commented on CODEC-125:
I think part of the problem might be the encoding.
It looks as
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13069969#comment-13069969
]
Matthew Pocock commented on CODEC-125:
--
* @author tags are discouraged in code
I
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13070019#comment-13070019
]
Sebb commented on CODEC-125:
Thanks!
Sorry, should have made it clear that the AL headers can
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13070068#comment-13070068
]
Matthew Pocock commented on CODEC-125:
--
No problem - it was probably about the same
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13070089#comment-13070089
]
Gary D. Gregory commented on CODEC-125:
---
I still have problems with the patch
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13069614#comment-13069614
]
Sebb commented on CODEC-125:
Unfortunately the file was attached without granting ASF
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13069618#comment-13069618
]
Sebb commented on CODEC-125:
Also, the code uses the method String#isEmpty() which is Java
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13069629#comment-13069629
]
Sebb commented on CODEC-125:
Having fixed the Java 1.6 problems, I was able to run the tests
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13069736#comment-13069736
]
Matthew Pocock commented on CODEC-125:
--
Sebb, good catch on String#isEmpty(). I've
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13069873#comment-13069873
]
Sebb commented on CODEC-125:
@Gary - looks like the code is not picking up the resources. What
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13058586#comment-13058586
]
Matthew Pocock commented on CODEC-125:
--
I have renamed the bmpm package to bm. Do you
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13058596#comment-13058596
]
Matthew Pocock commented on CODEC-125:
--
As a data point, the patch applies correctly
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13058180#comment-13058180
]
Gary D. Gregory commented on CODEC-125:
---
Hi Matthiew:
Thank you for the 2nd patch.
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13057382#comment-13057382
]
Matthew Pocock commented on CODEC-125:
--
Hi Gary,
This code is a port of some PHP
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13057393#comment-13057393
]
Matthew Pocock commented on CODEC-125:
--
Re test failures, I have all tests passing on
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13057439#comment-13057439
]
Matthew Pocock commented on CODEC-125:
--
Got it. On linux and in intellij, the
[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13057442#comment-13057442
]
Gary D. Gregory commented on CODEC-125:
---
Sounds good Matthew. The default code page
69 matches
Mail list logo
