[jira] [Commented] (CODEC-174) Improve performance of Beider Morse encoder

[ https://issues.apache.org/jira/browse/CODEC-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13833782#comment-13833782 ] Gary Gregory commented on CODEC-174: Do we think we are done with this one? We can

[jira] [Commented] (CODEC-174) Improve performance of Beider Morse encoder

[ https://issues.apache.org/jira/browse/CODEC-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13829810#comment-13829810 ] Thomas Champagne commented on CODEC-174: Currenty, in the trunk, I think my last

[jira] [Commented] (CODEC-174) Improve performance of Beider Morse encoder

[ https://issues.apache.org/jira/browse/CODEC-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13829906#comment-13829906 ] Thomas Neidhart commented on CODEC-174: --- See my comment above, in r1542831 I did

[jira] [Commented] (CODEC-174) Improve performance of Beider Morse encoder

[ https://issues.apache.org/jira/browse/CODEC-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13829979#comment-13829979 ] Gary Gregory commented on CODEC-174: @Thomas

[jira] [Commented] (CODEC-174) Improve performance of Beider Morse encoder

[ https://issues.apache.org/jira/browse/CODEC-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13829991#comment-13829991 ] Thomas Neidhart commented on CODEC-174: --- The semantic has not changed: * Before a

[jira] [Commented] (CODEC-174) Improve performance of Beider Morse encoder

[ https://issues.apache.org/jira/browse/CODEC-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13830254#comment-13830254 ] Thomas Neidhart commented on CODEC-174: --- In r1544659, I reverted the change from Set

[jira] [Commented] (CODEC-174) Improve performance of Beider Morse encoder

[ https://issues.apache.org/jira/browse/CODEC-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13829573#comment-13829573 ] Gary Gregory commented on CODEC-174: Are we done with this ticket? Improve

[jira] [Commented] (CODEC-174) Improve performance of Beider Morse encoder

[ https://issues.apache.org/jira/browse/CODEC-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13824964#comment-13824964 ] Thomas Neidhart commented on CODEC-174: --- In r1542831, I did also improve the

[jira] [Commented] (CODEC-174) Improve performance of Beider Morse encoder

[ https://issues.apache.org/jira/browse/CODEC-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13824641#comment-13824641 ] Matthew Pocock commented on CODEC-174: -- These patches look OK to me. I chose maps/sets

[jira] [Commented] (CODEC-174) Improve performance of Beider Morse encoder

[ https://issues.apache.org/jira/browse/CODEC-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13820069#comment-13820069 ] Gary Gregory commented on CODEC-174: Please reattach TestCacheSubSequence.java with an

[jira] [Commented] (CODEC-174) Improve performance of Beider Morse encoder

[ https://issues.apache.org/jira/browse/CODEC-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13820275#comment-13820275 ] Gary Gregory commented on CODEC-174: Added the performance test in

[jira] [Commented] (CODEC-174) Improve performance of Beider Morse encoder

[ https://issues.apache.org/jira/browse/CODEC-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13820465#comment-13820465 ] Gary Gregory commented on CODEC-174: Small (4-5%) but consistent performance gain with

[jira] [Commented] (CODEC-174) Improve performance of Beider Morse encoder

[ https://issues.apache.org/jira/browse/CODEC-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13820478#comment-13820478 ] Gary Gregory commented on CODEC-174: Applied patch

[jira] [Commented] (CODEC-174) Improve performance of Beider Morse encoder

[ https://issues.apache.org/jira/browse/CODEC-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818328#comment-13818328 ] Gary Gregory commented on CODEC-174: I applied Sebb's suggestion from

[jira] [Commented] (CODEC-174) Improve performance of Beider Morse encoder

[ https://issues.apache.org/jira/browse/CODEC-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818330#comment-13818330 ] Gary Gregory commented on CODEC-174: For the other Clirr reports, does this breakage

[jira] [Commented] (CODEC-174) Improve performance of Beider Morse encoder

[ https://issues.apache.org/jira/browse/CODEC-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13817457#comment-13817457 ] Thomas Neidhart commented on CODEC-174: --- btw. after the patches have been applied,

[jira] [Commented] (CODEC-174) Improve performance of Beider Morse encoder

[ https://issues.apache.org/jira/browse/CODEC-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13817877#comment-13817877 ] Sebb commented on CODEC-174: One of the changes is the following: Return type of method

[jira] [Commented] (CODEC-174) Improve performance of Beider Morse encoder

[ https://issues.apache.org/jira/browse/CODEC-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13816393#comment-13816393 ] Gary Gregory commented on CODEC-174: Thomas, Thank you for your patches. I've

[jira] [Commented] (CODEC-174) Improve performance of Beider Morse encoder

[ https://issues.apache.org/jira/browse/CODEC-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812902#comment-13812902 ] Gary Gregory commented on CODEC-174: Hi Thomas, Thank you for your contribution. A

[jira] [Commented] (CODEC-174) Improve performance of Beider Morse encoder

[ https://issues.apache.org/jira/browse/CODEC-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812958#comment-13812958 ] Thomas Champagne commented on CODEC-174: The patches are based on top of trunk :