[
https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844098#comment-16844098
]
Gilles commented on GEOMETRY-29:
bq. Is there a formatter
You could ask on the ML; more
[
https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844021#comment-16844021
]
Sven Rathgeber commented on GEOMETRY-29:
{quote}There were some additional nits:
[
https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843973#comment-16843973
]
Gilles commented on GEOMETRY-29:
Note: I'd guess that it is possible to "merge" commits
[
https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843970#comment-16843970
]
Gilles commented on GEOMETRY-29:
Thanks.
There were some additional nits: See commit
7a
[
https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843770#comment-16843770
]
Sven Rathgeber commented on GEOMETRY-29:
[~erans], I have added a commit to the
[
https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843729#comment-16843729
]
Gilles commented on GEOMETRY-29:
[~rathgeber], could you please fix all the errors repor
[
https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843580#comment-16843580
]
Matt Juntunen commented on GEOMETRY-29:
---
[~erans], can you please merge this PR? I
[
https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814176#comment-16814176
]
Sven Rathgeber commented on GEOMETRY-29:
{quote}make origin computed instead of
[
https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813974#comment-16813974
]
Matt Juntunen commented on GEOMETRY-29:
---
{quote}A user guide would be welcome...
{
[
https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813965#comment-16813965
]
Gilles commented on GEOMETRY-29:
No. I'm looking from afar, and I mostly rely on you un
[
https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813961#comment-16813961
]
Matt Juntunen commented on GEOMETRY-29:
---
Sounds good. [~rathgeber], could you make
[
https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16811330#comment-16811330
]
Gilles commented on GEOMETRY-29:
{quote}what do you think?
{quote}
I'd assume that if yo
[
https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809395#comment-16809395
]
Matt Juntunen commented on GEOMETRY-29:
---
I just realized that the PR isn't linked
[
https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809389#comment-16809389
]
Matt Juntunen commented on GEOMETRY-29:
---
This PR is looking good. [~erans], what d
[
https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16801399#comment-16801399
]
Matt Juntunen commented on GEOMETRY-29:
---
Thanks, [~rathgeber]! I added some commen
[
https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800653#comment-16800653
]
Sven Rathgeber commented on GEOMETRY-29:
I have added a pull request:
[https://
[
https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791829#comment-16791829
]
Matt Juntunen commented on GEOMETRY-29:
---
{quote}I don't see the use cases for hash
[
https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791700#comment-16791700
]
Sven Rathgeber commented on GEOMETRY-29:
This code is generated by eclipse (Vers
[
https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791651#comment-16791651
]
Matt Juntunen commented on GEOMETRY-29:
---
{quote}hmm, what do you picture here ? ..
[
https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791523#comment-16791523
]
Sven Rathgeber commented on GEOMETRY-29:
{quote}add {{equals}}, {{hashCode}} met
[
https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790499#comment-16790499
]
Matt Juntunen commented on GEOMETRY-29:
---
Great! No, I haven't done anything on thi
[
https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790377#comment-16790377
]
Sven Rathgeber commented on GEOMETRY-29:
{quote}feel free to work on this if you
[
https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771049#comment-16771049
]
Matt Juntunen commented on GEOMETRY-29:
---
bq. Should rather be removed.
I agree. I
[
https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16770852#comment-16770852
]
Gilles commented on GEOMETRY-29:
{quote}
// return this since now immutable
Plan
[
https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16770787#comment-16770787
]
Sven Rathgeber commented on GEOMETRY-29:
That looks good and consistent to me.
{
[
https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16770729#comment-16770729
]
Matt Juntunen commented on GEOMETRY-29:
---
Here are some more details of what I'm pi
26 matches
Mail list logo
