[jira] [Commented] (GEOMETRY-92) Segment is not mathematically correct

2020-05-05 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100386#comment-17100386 ] Matt Juntunen commented on GEOMETRY-92: --- Added in commit eee258978cae8fe4987c2155d

[jira] [Commented] (GEOMETRY-92) Segment is not mathematically correct

2020-05-05 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100136#comment-17100136 ] Gilles Sadowski commented on GEOMETRY-92: - I didn't have a closer look as it see

[jira] [Commented] (GEOMETRY-92) Segment is not mathematically correct

2020-05-05 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100074#comment-17100074 ] Matt Juntunen commented on GEOMETRY-92: --- Last changes are in. I ended up just rena

[jira] [Commented] (GEOMETRY-92) Segment is not mathematically correct

2020-05-04 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099161#comment-17099161 ] Gilles Sadowski commented on GEOMETRY-92: - LGTM, except perhaps that I would not

[jira] [Commented] (GEOMETRY-92) Segment is not mathematically correct

2020-05-04 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098951#comment-17098951 ] Matt Juntunen commented on GEOMETRY-92: --- [~erans], I've implemented the changes we

[jira] [Commented] (GEOMETRY-92) Segment is not mathematically correct

2020-04-24 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17091511#comment-17091511 ] Matt Juntunen commented on GEOMETRY-92: --- I don't like the idea of a namespace clas

[jira] [Commented] (GEOMETRY-92) Segment is not mathematically correct

2020-04-23 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090577#comment-17090577 ] Gilles Sadowski commented on GEOMETRY-92: - {quote}Are you suggesting that all cl

[jira] [Commented] (GEOMETRY-92) Segment is not mathematically correct

2020-04-22 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089593#comment-17089593 ] Matt Juntunen commented on GEOMETRY-92: --- bq. What I try to aim at is that classes

[jira] [Commented] (GEOMETRY-92) Segment is not mathematically correct

2020-04-21 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088760#comment-17088760 ] Gilles Sadowski commented on GEOMETRY-92: - bq. standardize the convex subline im

[jira] [Commented] (GEOMETRY-92) Segment is not mathematically correct

2020-04-21 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088574#comment-17088574 ] Matt Juntunen commented on GEOMETRY-92: --- bq. But the argument is that what is good

[jira] [Commented] (GEOMETRY-92) Segment is not mathematically correct

2020-04-20 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17087707#comment-17087707 ] Gilles Sadowski commented on GEOMETRY-92: - {quote}Line3D.Span3D seems redundant

[jira] [Commented] (GEOMETRY-92) Segment is not mathematically correct

2020-04-20 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17087637#comment-17087637 ] Matt Juntunen commented on GEOMETRY-92: --- bq. Span is a nested class and it does no

[jira] [Commented] (GEOMETRY-92) Segment is not mathematically correct

2020-04-19 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17087278#comment-17087278 ] Gilles Sadowski commented on GEOMETRY-92: - bq. I'm not seeing a benefit from hav

[jira] [Commented] (GEOMETRY-92) Segment is not mathematically correct

2020-04-19 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17087057#comment-17087057 ] Matt Juntunen commented on GEOMETRY-92: --- I'm not seeing a benefit from having the

[jira] [Commented] (GEOMETRY-92) Segment is not mathematically correct

2020-04-19 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17086952#comment-17086952 ] Gilles Sadowski commented on GEOMETRY-92: - {quote}they will be used quite freque

[jira] [Commented] (GEOMETRY-92) Segment is not mathematically correct

2020-04-19 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17086922#comment-17086922 ] Matt Juntunen commented on GEOMETRY-92: --- {quote}...couldn't they all be a nested c

[jira] [Commented] (GEOMETRY-92) Segment is not mathematically correct

2020-04-18 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17086691#comment-17086691 ] Gilles Sadowski commented on GEOMETRY-92: - bq. [...] further thought [...] Sinc

[jira] [Commented] (GEOMETRY-92) Segment is not mathematically correct

2020-04-17 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17086235#comment-17086235 ] Matt Juntunen commented on GEOMETRY-92: --- PR is in: https://github.com/apache/commo

[jira] [Commented] (GEOMETRY-92) Segment is not mathematically correct

2020-04-17 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17086205#comment-17086205 ] Matt Juntunen commented on GEOMETRY-92: --- This is done on my working branch. Howeve

[jira] [Commented] (GEOMETRY-92) Segment is not mathematically correct

2020-04-05 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17075988#comment-17075988 ] Matt Juntunen commented on GEOMETRY-92: --- I've been working on this here: [https:/

[jira] [Commented] (GEOMETRY-92) Segment is not mathematically correct

2020-03-31 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072306#comment-17072306 ] Matt Juntunen commented on GEOMETRY-92: --- bq. I admit that I still do not grasp the

[jira] [Commented] (GEOMETRY-92) Segment is not mathematically correct

2020-03-31 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072185#comment-17072185 ] Gilles Sadowski commented on GEOMETRY-92: - I admit that I still do not grasp the

[jira] [Commented] (GEOMETRY-92) Segment is not mathematically correct

2020-03-31 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072131#comment-17072131 ] Matt Juntunen commented on GEOMETRY-92: --- When I said that things were independent

[jira] [Commented] (GEOMETRY-92) Segment is not mathematically correct

2020-03-31 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071978#comment-17071978 ] Gilles Sadowski commented on GEOMETRY-92: - I don't know whether when talk about

[jira] [Commented] (GEOMETRY-92) Segment is not mathematically correct

2020-03-31 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071918#comment-17071918 ] Matt Juntunen commented on GEOMETRY-92: --- No, they represent different concepts, re

[jira] [Commented] (GEOMETRY-92) Segment is not mathematically correct

2020-03-31 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071797#comment-17071797 ] Gilles Sadowski commented on GEOMETRY-92: - Aren't they supposed to be same in 2D

[jira] [Commented] (GEOMETRY-92) Segment is not mathematically correct

2020-03-31 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071775#comment-17071775 ] Matt Juntunen commented on GEOMETRY-92: --- {{Line}} implements the {{Hyperplane}} in

[jira] [Commented] (GEOMETRY-92) Segment is not mathematically correct

2020-03-31 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071752#comment-17071752 ] Gilles Sadowski commented on GEOMETRY-92: - What's the difference between the cur

[jira] [Commented] (GEOMETRY-92) Segment is not mathematically correct

2020-03-31 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071685#comment-17071685 ] Matt Juntunen commented on GEOMETRY-92: --- {quote}How about ... .{{Line}} (instead o

[jira] [Commented] (GEOMETRY-92) Segment is not mathematically correct

2020-03-30 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071059#comment-17071059 ] Gilles Sadowski commented on GEOMETRY-92: - How about * {{Line}} (instead of {{Fu