[
https://issues.apache.org/jira/browse/IO-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506882#comment-16506882
]
Bruno P. Kinoshita commented on IO-554:
---
TL;DR;
* *2.5 did not close the stream*
* *2.6 closed the
[
https://issues.apache.org/jira/browse/IO-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506089#comment-16506089
]
Gary Gregory commented on IO-554:
-
We should pull this change in, this is just a plain old bug.
>
[
https://issues.apache.org/jira/browse/IO-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240022#comment-16240022
]
Bernd Eckenfels commented on IO-554:
2.5 and before did not close the file. So this is a change which
[
https://issues.apache.org/jira/browse/IO-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240019#comment-16240019
]
Bruno P. Kinoshita commented on IO-554:
---
>Fact is, if we pull that one in, then the next version will
[
https://issues.apache.org/jira/browse/IO-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240010#comment-16240010
]
Jochen Wiedmann commented on IO-554:
Fact is, if we pull that one in, then the next version will behave
[
https://issues.apache.org/jira/browse/IO-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239738#comment-16239738
]
Bruno P. Kinoshita commented on IO-554:
---
[~joc...@apache.org]
>For the sake of binary compatibility,
[
https://issues.apache.org/jira/browse/IO-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239595#comment-16239595
]
Michele Mariotti commented on IO-554:
-
There is already a method which closes the input stream: it is
[
https://issues.apache.org/jira/browse/IO-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239579#comment-16239579
]
Jochen Wiedmann commented on IO-554:
For the sake of binary compatibility, I'd suggest an alternate
[
https://issues.apache.org/jira/browse/IO-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239495#comment-16239495
]
Michele Mariotti commented on IO-554:
-
test case added
> FileUtils.copyToFile(InputStream source, File
[
https://issues.apache.org/jira/browse/IO-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239471#comment-16239471
]
Bernd Eckenfels commented on IO-554:
Can you add a test case as well?
> FileUtils.copyToFile(InputStream
[
https://issues.apache.org/jira/browse/IO-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239466#comment-16239466
]
Michele Mariotti commented on IO-554:
-
Created Pull Request
[
https://issues.apache.org/jira/browse/IO-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239465#comment-16239465
]
ASF GitHub Bot commented on IO-554:
---
GitHub user mmariotti opened a pull request:
[
https://issues.apache.org/jira/browse/IO-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239364#comment-16239364
]
Bruno P. Kinoshita commented on IO-554:
---
Nice catch [~mmariotti]
Would you like to submit a pull
13 matches
Mail list logo
