Liviu Tudor created POOL-224:
--------------------------------

             Summary: findbugs performance warnings on StackKeyedObjectPool
                 Key: POOL-224
                 URL: https://issues.apache.org/jira/browse/POOL-224
             Project: Commons Pool
          Issue Type: Improvement
    Affects Versions: 1.6
            Reporter: Liviu Tudor
            Priority: Trivial
             Fix For: 1.6.1


Findbugs is currently showing 2 performance warnings in 
{{StackKeyedObjectPool}} due to the usage of 
{code:java}new Integer(value){code}
as opposed to 
{code:java}Integer.valueOf(value){code}

Also, it seems we create a new {{Integer}} instance each time we need to store 
1 in the map -- since the {{Integer}} class is immutable, we can actually share 
one single instance for these cases, and reduce pressure on the GC, and this 
patch addresses this minor optimization as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to