[ 
https://issues.apache.org/jira/browse/VFS-367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary D. Gregory updated VFS-367:
--------------------------------

    Description: 
As a call site, I want to say {{fileObject.isFile()}}, not 
{{FileType.FILE.equals(fileObject.getType())}} or {{fileObject.getType() == 
FileType.FILE}}

It turns out this {{equals()/==}} pattern is repeated internally quit a bit. 
Refactor that to use the new API.

Same idea for FileName isFile (but there are fewer call sites to refactor.)

  was:
As a call site, I want to say {{fileObject.isFile()}}, not 
{{FileType.FILE.equals(fileObject.getType())}}

It turns out this {{equals()}} pattern is repeated internally quit a bit with 
both equals, and ==. I'll refactor that to use the new API.

Same idea for FileName (but there are fewer call sites to refactor.)

        Summary: Add APIs FileObject isFile(), FileObject isFolder(), and 
FileName isFile()  (was: Add API FileObject and FileName isFile())
    
> Add APIs FileObject isFile(), FileObject isFolder(), and FileName isFile()
> --------------------------------------------------------------------------
>
>                 Key: VFS-367
>                 URL: https://issues.apache.org/jira/browse/VFS-367
>             Project: Commons VFS
>          Issue Type: Improvement
>    Affects Versions: 1.0, 2.0
>         Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500)
> Maven home: C:\Java\apache-maven-3.0.3\bin\..
> Java version: 1.6.0_24, vendor: Sun Microsystems Inc.
> Java home: C:\Program Files\Java\jdk1.6.0_24\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
>            Reporter: Gary D. Gregory
>            Assignee: Gary D. Gregory
>             Fix For: 2.1
>
>
> As a call site, I want to say {{fileObject.isFile()}}, not 
> {{FileType.FILE.equals(fileObject.getType())}} or {{fileObject.getType() == 
> FileType.FILE}}
> It turns out this {{equals()/==}} pattern is repeated internally quit a bit. 
> Refactor that to use the new API.
> Same idea for FileName isFile (but there are fewer call sites to refactor.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to