[jira] Commented: (IO-145) File Comparator implementations

2007-12-07 Thread Stephen Colebourne (JIRA)
[ https://issues.apache.org/jira/browse/IO-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549369 ] Stephen Colebourne commented on IO-145: --- I support the addition of these as a new subpackage of [io]. I also suppo

[jira] Commented: (IO-145) File Comparator implementations

2007-12-06 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549260 ] Niall Pemberton commented on IO-145: I would agree with you both except that the implementations I attached include

[jira] Commented: (IO-145) File Comparator implementations

2007-12-06 Thread Stephen Kestle (JIRA)
[ https://issues.apache.org/jira/browse/IO-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549184 ] Stephen Kestle commented on IO-145: --- Yeah, I could go either way on that. There's not necessarily a "need" to have a

[jira] Commented: (IO-145) File Comparator implementations

2007-12-06 Thread Matt Benson (JIRA)
[ https://issues.apache.org/jira/browse/IO-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549171 ] Matt Benson commented on IO-145: Agreed that "dependency free" is an aim for all Commons components, but in this case th

[jira] Commented: (IO-145) File Comparator implementations

2007-12-06 Thread Matt Benson (JIRA)
[ https://issues.apache.org/jira/browse/IO-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549157 ] Matt Benson commented on IO-145: Again, I don't really buy the overlap of [io] having its own reverse comparator impleme

[jira] Commented: (IO-145) File Comparator implementations

2007-12-06 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/IO-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549133 ] Gary Gregory commented on IO-145: - Nit: LastmodifiedFileComparator should be LastModifiedFileComparator > File Compara