[
https://issues.apache.org/jira/browse/LANG-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541940
]
Ben Speakmon commented on LANG-360:
---
Looks good. +1.
> Why does appendIdentityToString return null?
> --
[
https://issues.apache.org/jira/browse/LANG-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540224
]
Paul Benedict commented on LANG-360:
Stephen says: "This method is meant to simulate the identity toString". Based
[
https://issues.apache.org/jira/browse/LANG-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540209
]
Henri Yandell commented on LANG-360:
The problem with the method lies with the automagical creation. Passing in nul
[
https://issues.apache.org/jira/browse/LANG-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539914
]
Stephen Colebourne commented on LANG-360:
-
Are we not over-thinking this? The method does what it says it does,
[
https://issues.apache.org/jira/browse/LANG-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539896
]
Henri Yandell commented on LANG-360:
Brain kicks in Also, I wouldn't expect:
ObjectUtils.appendIdentityToStrin
[
https://issues.apache.org/jira/browse/LANG-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539894
]
Henri Yandell commented on LANG-360:
Prodding it more - it's "identityToString", meaning the identity toString()
m
[
https://issues.apache.org/jira/browse/LANG-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538854
]
Ben Speakmon commented on LANG-360:
---
I like Henri's second suggestion better. Between that and deprecating the old
m
[
https://issues.apache.org/jira/browse/LANG-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538844
]
Jörg Gottschling commented on LANG-360:
---
>> Perhaps we can call it simply "appendIdentity" ? Funny that the curre
[
https://issues.apache.org/jira/browse/LANG-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538796
]
Henri Yandell commented on LANG-360:
+1 on 'appendIdentity'.
I also don't like the first parameter being nullable.
[
https://issues.apache.org/jira/browse/LANG-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538790
]
Paul Benedict commented on LANG-360:
After some further ruminations, I favor deprecating the current method (Ben's
[
https://issues.apache.org/jira/browse/LANG-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538690
]
Ben Speakmon commented on LANG-360:
---
It's unfortunate that the API here forces the user to null-protect his
paramete
[
https://issues.apache.org/jira/browse/LANG-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538682
]
Jörg Gottschling commented on LANG-360:
---
Yes, this behavior is in sync with the javadoc. That's where I found it
[
https://issues.apache.org/jira/browse/LANG-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538664
]
Paul Benedict commented on LANG-360:
What's ironic is that the current behavior is in perfect line with the javadoc
[
https://issues.apache.org/jira/browse/LANG-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538659
]
Henri Yandell commented on LANG-360:
Definitely agreed that I wouldn't expect the chained style to fail just becaus
14 matches
Mail list logo