[
https://issues.apache.org/jira/browse/MATH-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564637#action_12564637
]
Phil Steitz commented on MATH-181:
--
Yes, I think the call to reduce can be removed.
> Speci
[
https://issues.apache.org/jira/browse/MATH-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564536#action_12564536
]
Niall Pemberton commented on MATH-181:
--
I have no idea - it was in the original construc
[
https://issues.apache.org/jira/browse/MATH-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564531#action_12564531
]
Luc Maisonobe commented on MATH-181:
I have checked the ideas I had about denominator. Th
[
https://issues.apache.org/jira/browse/MATH-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563124#action_12563124
]
Luc Maisonobe commented on MATH-181:
The patch has been commited as of r615856, including
[
https://issues.apache.org/jira/browse/MATH-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12562953#action_12562953
]
Phil Steitz commented on MATH-181:
--
Second patch looks good to me. One thing I would add is
[
https://issues.apache.org/jira/browse/MATH-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12562626#action_12562626
]
Luc Maisonobe commented on MATH-181:
I understand your rationale here. I also don't like
[
https://issues.apache.org/jira/browse/MATH-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12562019#action_12562019
]
Niall Pemberton commented on MATH-181:
--
Yes, I mostly just copied the existing construct
[
https://issues.apache.org/jira/browse/MATH-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561796#action_12561796
]
Luc Maisonobe commented on MATH-181:
I find the javadoc of the private four arguments con
